From: Andrew Lunn <andrew@lunn.ch>
To: Roosen Henri <Henri.Roosen@ginzinger.com>
Cc: 'Florian Fainelli' <f.fainelli@gmail.com>,
"david.daney@cavium.com" <david.daney@cavium.com>,
"buytenh@wantstofly.org" <buytenh@wantstofly.org>,
"grant.likely@secretlab.ca" <grant.likely@secretlab.ca>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: Commit-8b63ec18 breaks setting PHY pad-skew settings
Date: Tue, 22 Dec 2015 11:18:36 +0100 [thread overview]
Message-ID: <20151222101836.GA2373@lunn.ch> (raw)
In-Reply-To: <FC629F1A536C6F42B960B5E32E20BD356A969BC7@exc2.buero.ginzinger.com>
> Unfortunately the patch is incomplete: it only fixes the issue for
> the KSZ9021. Please have a look at the funcion ksz9031_config_init()
> which has the the same (broken) search for the parent node.
Ah, sorry missed that. I was a bit blinkered, the issue was report for
KSZ9021 and i did not look further.
> As both the code for KSZ9021 as well as the code for KSZ9031 parse
> the same pad skew settings from the OF node (and to prevent
> incomplete fixes in the future), I think this code is a candidate to
> be cleaned up. Or is cooking up a similar patch for the KSZ9031 as
> for the KSZ9021 preferred?
Both would be best. We probably need a minimal fix we can get included
fast, and then having a cleanup patch merged during the next merge
window would be nice.
> Additionally, if this is a deprecated feature (like the commit
> states), then the devicetree binding documentation
> (Documentation/devicetree/bindings/net/micrel-ksz90x1.txt) should be
> updated. At least the deprecated example for autodetected PHY's
> should be corrected/removed.
I submitted a patch for that already.
https://www.mail-archive.com/netdev@vger.kernel.org/msg90932.html
It however does not seem to of made its way into net-next. If you
agree with it, please send an reviewed-by, or an Acked-by...
Andrew
prev parent reply other threads:[~2015-12-22 10:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <FC629F1A536C6F42B960B5E32E20BD356A967AF0@exc2.buero.ginzinger.com>
2015-12-21 19:50 ` Commit-8b63ec18 breaks setting PHY pad-skew settings Florian Fainelli
2015-12-22 10:04 ` AW: " Roosen Henri
2015-12-22 10:18 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151222101836.GA2373@lunn.ch \
--to=andrew@lunn.ch \
--cc=Henri.Roosen@ginzinger.com \
--cc=buytenh@wantstofly.org \
--cc=davem@davemloft.net \
--cc=david.daney@cavium.com \
--cc=f.fainelli@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).