Re: [PATCH V1 08/16] i40iw: add files for iwarp interface

From: Faisal Latif <faisal.latif@intel.com>
To: Or Gerlitz <ogerlitz@mellanox.com>
Cc: "dledford@redhat.com" <dledford@redhat.com>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
	"e1000-rdma@lists.sourceforge.net"
	<e1000-rdma@lists.sourceforge.net>
Subject: Re: [PATCH V1 08/16] i40iw: add files for iwarp interface
Date: Thu, 24 Dec 2015 13:36:33 -0600	[thread overview]
Message-ID: <20151224193633.GA19560@flatif-MOBL1> (raw)
In-Reply-To: <567BABE4.8080302@mellanox.com>

On Thu, Dec 24, 2015 at 10:25:08AM +0200, Or Gerlitz wrote:
> On 12/24/2015 9:31 AM, Faisal Latif wrote:
> >On Wed, Dec 23, 2015 at 08:42:01AM -0800, Or Gerlitz wrote:
> >>On 12/22/2015 1:13 AM, Faisal Latif wrote:
> >>>+
> >>>+enum i40iw_memreg_type {
> >>>+	IW_MEMREG_TYPE_MEM = 0x0000,
> >>>+	IW_MEMREG_TYPE_QP = 0x0001,
> >>>+	IW_MEMREG_TYPE_CQ = 0x0002,
> >>>+	IW_MEMREG_TYPE_MW = 0x0003,
> >>>+	IW_MEMREG_TYPE_FMR = 0x0004,
> >>>+	IW_MEMREG_TYPE_FMEM = 0x0005,
> >>>+};
> >>Can't you re-use IB core values or derive that from the actual uverbs
> >>command?
> >I did not see anything which will have types that I needed.
> 
> what do you need? what is the role of this enum?

We register register memory from user library for qp and cq rings as well
as user memory registration and do need to distinguish in the driver.

> 
> >It will be confusing otherwise.
> 
> 
> >I will be reducing number of types from here though.
> 
> so why some of it can go? is that deal values which aren't used by the code

Yes, had added all different types for user requests. But For the time being, we will
just keep MEM, CQ, QP and add other as needed like Memory Windows.
> 
> Or.
> 
> >Thanks
> >Faisal
> 