From: Jiri Pirko <jiri@resnulli.us>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, yotamg@mellanox.com, idosch@mellanox.com,
eladr@mellanox.com, nogahf@mellanox.com, ogerlitz@mellanox.com
Subject: Re: [patch net 0/2] mlxsw: Couple of fixes
Date: Wed, 5 Oct 2016 13:14:51 +0200 [thread overview]
Message-ID: <20161005111451.GB2293@nanopsycho> (raw)
In-Reply-To: <20161004.202927.1650578832896717724.davem@davemloft.net>
Wed, Oct 05, 2016 at 02:29:27AM CEST, davem@davemloft.net wrote:
>From: Jiri Pirko <jiri@resnulli.us>
>Date: Tue, 4 Oct 2016 09:46:03 +0200
>
>> Couple of fixes from Yotam.
>
>Series applied, thanks.
>
>Note that needed_headroom is a request, rather than a guarantee, so you
>may in some rare cases need to realloc your headroom if the kernel was
>not able to meet your request.
We already do that:
if (unlikely(skb_headroom(skb) < MLXSW_TXHDR_LEN)) {
struct sk_buff *skb_orig = skb;
skb = skb_realloc_headroom(skb, MLXSW_TXHDR_LEN);
if (!skb) {
this_cpu_inc(mlxsw_sp_port->pcpu_stats->tx_dropped);
dev_kfree_skb_any(skb_orig);
return NETDEV_TX_OK;
}
}
next prev parent reply other threads:[~2016-10-05 11:14 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-04 7:46 [patch net 0/2] mlxsw: Couple of fixes Jiri Pirko
2016-10-04 7:46 ` [patch net 1/2] mlxsw: spectrum: Fix misuse of hard_header_len Jiri Pirko
2016-10-04 7:46 ` [patch net 2/2] mlxsw: switchx2: " Jiri Pirko
2016-10-05 0:29 ` [patch net 0/2] mlxsw: Couple of fixes David Miller
2016-10-05 11:14 ` Jiri Pirko [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-11-17 17:33 [PATCH " Ido Schimmel
2020-11-18 19:09 ` Jakub Kicinski
2019-12-29 11:40 Ido Schimmel
2019-12-29 20:30 ` David Miller
2018-10-29 14:26 Ido Schimmel
2018-10-30 3:48 ` David Miller
2018-10-04 15:48 Ido Schimmel
2018-10-04 16:56 ` David Miller
2018-10-04 17:05 ` Ido Schimmel
2018-02-27 11:56 [patch net 0/2] mlxsw: couple " Jiri Pirko
2018-02-27 19:39 ` David Miller
2018-02-28 7:09 ` Jiri Pirko
2018-01-10 10:42 Jiri Pirko
2018-01-10 20:58 ` David Miller
2017-08-04 12:12 [patch net 0/2] mlxsw: Couple " Jiri Pirko
2017-08-04 18:17 ` David Miller
2017-05-18 7:18 [patch net 0/2] mlxsw: couple " Jiri Pirko
2017-05-18 15:05 ` David Miller
2017-03-14 12:59 [patch net 0/2] mlxsw: Couple " Jiri Pirko
2017-03-14 18:35 ` David Miller
2016-11-11 10:20 Jiri Pirko
2016-11-13 17:48 ` David Miller
2016-10-25 9:25 Jiri Pirko
2016-10-28 17:44 ` David Miller
2016-09-08 6:16 [patch net 0/2] mlxsw: couple " Jiri Pirko
2016-09-09 23:57 ` David Miller
2016-08-24 9:18 Jiri Pirko
2016-08-24 16:39 ` David Miller
2016-06-17 13:09 Jiri Pirko
2016-06-18 4:58 ` David Miller
2016-06-09 7:51 Jiri Pirko
2016-06-09 18:21 ` David Miller
2016-05-06 20:18 [patch net 0/2] mlxsw: Couple " Jiri Pirko
2016-05-06 22:33 ` David Miller
2016-03-07 8:24 [patch net 0/2] mlxsw: couple " Jiri Pirko
2015-10-08 13:17 Jiri Pirko
2015-10-11 12:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161005111451.GB2293@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=eladr@mellanox.com \
--cc=idosch@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=nogahf@mellanox.com \
--cc=ogerlitz@mellanox.com \
--cc=yotamg@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).