From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [PATCH net-next 1/3] net: ethtool: add support for forward error correction modes Date: Thu, 6 Jul 2017 16:27:49 -0700 Message-ID: <20170706162749.4f51f36d@cakuba.netronome.com> References: <1498331985-8525-2-git-send-email-roopa@cumulusnetworks.com> <20170627032239.05cdc462@cakuba.netronome.com> <20170628134139.GB12559@lunn.ch> <20170628214751.shjgnh2mv7ihgcum@cumulusnetworks.com> <20170628180008.42059797@cakuba.netronome.com> <20170706120214.6076be46@cakuba.netronome.com> <20170706223324.GA24237@lunn.ch> <20170706231550.GC24237@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Casey Leedom , Dustin Byford , Roopa Prabhu , "davem@davemloft.net" , "linville@tuxdriver.com" , "netdev@vger.kernel.org" , "vidya.chowdary@gmail.com" , "olson@cumulusnetworks.com" , Manoj Malviya , Santosh Rastapur , "yuval.mintz@qlogic.com" , "odedw@mellanox.com" , "ariela@mellanox.com" , "galp@mellanox.com" , "jeffrey.t.kirsher@intel.com" To: Andrew Lunn Return-path: Received: from mx4.wp.pl ([212.77.101.11]:57930 "EHLO mx4.wp.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753037AbdGFX2B (ORCPT ); Thu, 6 Jul 2017 19:28:01 -0400 In-Reply-To: <20170706231550.GC24237@lunn.ch> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 7 Jul 2017 01:15:50 +0200, Andrew Lunn wrote: > > Even this feels too extreme for me. I think users would hate it. They > > did an ifup and swapped cables. They expect the OS/Driver/Firmware > > to continue trying to honor their ifup request. > > Lets take a look around at other subsystems.... > > What happens if you hot-unplug a SATA drive? > An MMC card? > A USB device? > A PCIe card? > A CPU? > An SDRAM? > > Do you know of any subsystem that tried to keep its configuration > across a hot unplug/plug event? I suspect they all require user space > to take some action to get the newly plugged hardware into operation. That was exactly my thinking initially, but I'm not so sure anymore because the layer to which configuration is applied does not reside on the portion of HW which is hot swapped. I'm very far from an expert on the PHY layer stuff but modules start at the PMA layer? If only IEEE defined for us what the behaviour should be :)