From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH net-next 1/3] net: ethtool: add support for forward error correction modes Date: Fri, 7 Jul 2017 02:56:01 +0200 Message-ID: <20170707005601.GG8810@lunn.ch> References: <20170628134139.GB12559@lunn.ch> <20170628214751.shjgnh2mv7ihgcum@cumulusnetworks.com> <20170628180008.42059797@cakuba.netronome.com> <20170706120214.6076be46@cakuba.netronome.com> <20170706223324.GA24237@lunn.ch> <20170706231550.GC24237@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jakub Kicinski , Dustin Byford , Roopa Prabhu , "davem@davemloft.net" , "linville@tuxdriver.com" , "netdev@vger.kernel.org" , "vidya.chowdary@gmail.com" , "olson@cumulusnetworks.com" , Manoj Malviya , Santosh Rastapur , "yuval.mintz@qlogic.com" , "odedw@mellanox.com" , "ariela@mellanox.com" , "galp@mellanox.com" , "jeffrey.t.kirsher@intel.com" To: Casey Leedom Return-path: Received: from vps0.lunn.ch ([178.209.37.122]:47378 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752673AbdGGA4N (ORCPT ); Thu, 6 Jul 2017 20:56:13 -0400 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: > If you choose to think of a cable unplug/plug event as "hot plug", then > the "reset" is the model that feels right. But I'll note that this is also > presupposing what the right model is for users. This is akin > to trying to decide what to make for dinner and deciding that a > hammer is the right tool. If we end up deciding on Cracked > Crab (or Tree Nuts for the vegans amongst us), then the > hammer is quite possibly a good answer. It also depends on the chef. A skilled chef knows how to use and abuse a hammer and can make quite good filo pastry using a hammer if need be. And when we are talking about SFP modules, we are not talking about somebody who can just about boiling an egg and put bread in the toaster. Anybody using these SFP modules knows a lot about networking, is a power user, and probably does not rely on plug and pray. Andrew