* [PATCH][net-next] net: qualcomm: rmnet: remove unused variable priv
@ 2017-08-31 14:07 Colin King
2017-08-31 20:34 ` Subash Abhinov Kasiviswanathan
2017-09-02 1:34 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2017-08-31 14:07 UTC (permalink / raw)
To: Subash Abhinov Kasiviswanathan, David S . Miller, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
priv is being assigned but is never used, so remove it.
Cleans up clang build warning:
"warning: Value stored to 'priv' is never read"
Fixes: ceed73a2cf4a ("drivers: net: ethernet: qualcomm: rmnet: Initial implementation")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c b/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c
index c8b573d28dcf..bf7455fdafcc 100644
--- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c
+++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c
@@ -73,9 +73,6 @@ static const struct net_device_ops rmnet_vnd_ops = {
*/
void rmnet_vnd_setup(struct net_device *rmnet_dev)
{
- struct rmnet_priv *priv;
-
- priv = netdev_priv(rmnet_dev);
netdev_dbg(rmnet_dev, "Setting up device %s\n", rmnet_dev->name);
rmnet_dev->netdev_ops = &rmnet_vnd_ops;
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH][net-next] net: qualcomm: rmnet: remove unused variable priv
2017-08-31 14:07 [PATCH][net-next] net: qualcomm: rmnet: remove unused variable priv Colin King
@ 2017-08-31 20:34 ` Subash Abhinov Kasiviswanathan
2017-09-02 1:34 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Subash Abhinov Kasiviswanathan @ 2017-08-31 20:34 UTC (permalink / raw)
To: Colin King; +Cc: David S . Miller, netdev, kernel-janitors, linux-kernel
On 2017-08-31 08:07, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> priv is being assigned but is never used, so remove it.
>
> Cleans up clang build warning:
> "warning: Value stored to 'priv' is never read"
>
> Fixes: ceed73a2cf4a ("drivers: net: ethernet: qualcomm: rmnet: Initial
> implementation")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c
> b/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c
> index c8b573d28dcf..bf7455fdafcc 100644
> --- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c
> +++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c
> @@ -73,9 +73,6 @@ static const struct net_device_ops rmnet_vnd_ops = {
> */
> void rmnet_vnd_setup(struct net_device *rmnet_dev)
> {
> - struct rmnet_priv *priv;
> -
> - priv = netdev_priv(rmnet_dev);
> netdev_dbg(rmnet_dev, "Setting up device %s\n", rmnet_dev->name);
>
> rmnet_dev->netdev_ops = &rmnet_vnd_ops;
Thanks for fixing this.
Acked-by: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][net-next] net: qualcomm: rmnet: remove unused variable priv
2017-08-31 14:07 [PATCH][net-next] net: qualcomm: rmnet: remove unused variable priv Colin King
2017-08-31 20:34 ` Subash Abhinov Kasiviswanathan
@ 2017-09-02 1:34 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-09-02 1:34 UTC (permalink / raw)
To: colin.king; +Cc: subashab, netdev, kernel-janitors, linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Thu, 31 Aug 2017 15:07:27 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> priv is being assigned but is never used, so remove it.
>
> Cleans up clang build warning:
> "warning: Value stored to 'priv' is never read"
>
> Fixes: ceed73a2cf4a ("drivers: net: ethernet: qualcomm: rmnet: Initial implementation")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-02 1:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-31 14:07 [PATCH][net-next] net: qualcomm: rmnet: remove unused variable priv Colin King
2017-08-31 20:34 ` Subash Abhinov Kasiviswanathan
2017-09-02 1:34 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).