From: Aaro Koskinen <aaro.koskinen@iki.fi>
To: Andrew Lunn <andrew@lunn.ch>
Cc: David Miller <davem@davemloft.net>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net] net: phy: marvell: Only configure RGMII delays when using RGMII
Date: Tue, 31 Oct 2017 23:29:54 +0200 [thread overview]
Message-ID: <20171031212953.4ctl5jptgi6wgdlu@darkstar.musicnaut.iki.fi> (raw)
In-Reply-To: <1509478288-27130-1-git-send-email-andrew@lunn.ch>
Hi,
On Tue, Oct 31, 2017 at 08:31:28PM +0100, Andrew Lunn wrote:
> The fix 5987feb38aa5 ("net: phy: marvell: logical vs bitwise OR typo")
> uncovered another bug in the Marvell PHY driver, which broke the
> Marvell OpenRD platform. It relies on the bootloader configuring the
> RGMII delays and does not specify a phy-mode in its device tree. The
> PHY driver should only configure RGMII delays if the phy mode
> indicates it is using RGMII. Without anything in device tree, the
> mv643xx Ethernet driver defaults to GMII.
>
> Fixes: 5987feb38aa5 ("net: phy: marvell: logical vs bitwise OR typo")
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Tested-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> Aaro
>
> Please can you test this and see if it fixes your OpenRD. This should
> cause it to leave the bootloader configuration alone. That will fix
> the regression for older DT blobs. Adding correct phy-mode properties
> can also be done. That would increase the robustness to bootloader
> changes.
Thanks, and yes, I guess also the DT should be updated...
A.
> drivers/net/phy/marvell.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c
> index 15cbcdba618a..4d02b27df044 100644
> --- a/drivers/net/phy/marvell.c
> +++ b/drivers/net/phy/marvell.c
> @@ -681,9 +681,11 @@ static int m88e1116r_config_init(struct phy_device *phydev)
> if (err < 0)
> return err;
>
> - err = m88e1121_config_aneg_rgmii_delays(phydev);
> - if (err < 0)
> - return err;
> + if (phy_interface_is_rgmii(phydev)) {
> + err = m88e1121_config_aneg_rgmii_delays(phydev);
> + if (err < 0)
> + return err;
> + }
>
> err = genphy_soft_reset(phydev);
> if (err < 0)
> --
> 2.14.1
>
next prev parent reply other threads:[~2017-10-31 21:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 19:31 [PATCH net] net: phy: marvell: Only configure RGMII delays when using RGMII Andrew Lunn
2017-10-31 21:29 ` Aaro Koskinen [this message]
2017-10-31 23:29 ` Florian Fainelli
2017-11-01 2:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171031212953.4ctl5jptgi6wgdlu@darkstar.musicnaut.iki.fi \
--to=aaro.koskinen@iki.fi \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).