From: Jiri Pirko <jiri@resnulli.us>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
netdev@vger.kernel.org, davem@davemloft.net, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, mlxsw@mellanox.com,
edumazet@google.com, alexander.h.duyck@intel.com,
willemb@google.com, john.fastabend@gmail.com
Subject: Re: [patch net-next v3 2/2] net: core: introduce mini_Qdisc and eliminate usage of tp->q for clsact fastpath
Date: Wed, 1 Nov 2017 11:30:52 +0100 [thread overview]
Message-ID: <20171101103052.GE1977@nanopsycho.orion> (raw)
In-Reply-To: <59F9A0FE.2040608@iogearbox.net>
Wed, Nov 01, 2017 at 11:25:02AM CET, daniel@iogearbox.net wrote:
>On 11/01/2017 03:12 AM, Alexei Starovoitov wrote:
>> On Tue, Oct 31, 2017 at 04:12:22PM +0100, Jiri Pirko wrote:
>> > From: Jiri Pirko <jiri@mellanox.com>
>[...]
>> I don't think it's great, but I don't have any suggestions on
>> how to avoid it, so I'm not objecting. Just disappointed that
>> you keep adding stuff to tc and messing with sw fast path only to
>> make parity with some obscure hw feature.
>
>tc became a sink for that over time.
Block sharing is not only useful for offloads. But I understand.
>
>> If it keeps going like this we'd need to come up with some new fast
>> hook for clsbpf in ingress/egress paths. We use it for
>> every packet, so extra loads are not great.
>> I guess they should be cache hits, but will take extra cache line.
>> All of the bugs in tc logic recently are not comforting either.
>
>+1
I don't see any effect of tc changes on clsbpf ingress/egress since
clsact was introduced. Could you point it out?
next prev parent reply other threads:[~2017-11-01 10:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 15:12 [patch net-next v3 0/2] net: core: introduce mini_Qdisc and eliminate usage of tp->q for clsact fastpath Jiri Pirko
2017-10-31 15:12 ` [patch net-next v3 1/2] net: sched: introduce chain_head_change callback Jiri Pirko
2017-10-31 15:12 ` [patch net-next v3 2/2] net: core: introduce mini_Qdisc and eliminate usage of tp->q for clsact fastpath Jiri Pirko
2017-11-01 2:12 ` Alexei Starovoitov
2017-11-01 8:18 ` Jiri Pirko
2017-11-01 16:11 ` Alexei Starovoitov
2017-11-02 11:27 ` Jiri Pirko
2017-11-01 10:25 ` Daniel Borkmann
2017-11-01 10:30 ` Jiri Pirko [this message]
2017-11-03 1:24 ` [patch net-next v3 0/2] " David Miller
2017-11-03 6:57 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171101103052.GE1977@nanopsycho.orion \
--to=jiri@resnulli.us \
--cc=alexander.h.duyck@intel.com \
--cc=alexei.starovoitov@gmail.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=john.fastabend@gmail.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).