From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH iproute2] Add "show" subcommand to "ip fou" Date: Thu, 16 Nov 2017 16:35:08 -0800 Message-ID: <20171116163508.2f57d4e7@xeon-e3> References: <20171101220333.5f73760f@shemminger-XPS-13-9360> <9F9BDF85-1400-4CA0-A852-02EE02E7B64C@apple.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: Greg Greenway Return-path: Received: from mail-pg0-f46.google.com ([74.125.83.46]:44816 "EHLO mail-pg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753738AbdKQAfQ (ORCPT ); Thu, 16 Nov 2017 19:35:16 -0500 Received: by mail-pg0-f46.google.com with SMTP id c123so616193pga.11 for ; Thu, 16 Nov 2017 16:35:16 -0800 (PST) In-Reply-To: <9F9BDF85-1400-4CA0-A852-02EE02E7B64C@apple.com> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 03 Nov 2017 10:19:22 -0700 Greg Greenway wrote: > On Nov 1, 2017, at 2:03 PM, Stephen Hemminger wrote: > > > > On Tue, 31 Oct 2017 13:00:47 -0700 > > Greg Greenway wrote: > > > >> + if (tb[FOU_ATTR_AF]) { > >> + family = rta_getattr_u8(tb[FOU_ATTR_AF]); > >> + if (family == AF_INET) > >> + family_str = "AF_INET"; > >> + else if (family == AF_INET6) > >> + family_str = "AF_INET6"; > >> + else > >> + family_str = "unknown"; > >> + fprintf(fp, "af %s ", family_str); > > > > The unwritten rule for ip commands is that the show function > > must format the output with same command syntax as the other commands set/add/delete. > > Since there is no "af AF_INET" option to ip fou, this breaks that convention. > > Either ignore the address family, change the add command, or output with same > > syntax (-6); preferably the latter. > > That makes sense. Here's a corrected version. It also avoids a trailing-space in the output. Yes, your followup looks correct but since it didn't follow the mailing list patch protocol it was not picked up and managed by patchwork. https://patchwork.ozlabs.org/patch/832717/ You need to post the patch as new patch (ie not a followup) with the "v2" designation in order to get it correctly picked up and managed by patchwork.