From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: Regression in 39461af74125 "bitmap: replace
 bitmap_{from,to}_u32array"
Date: Tue, 06 Feb 2018 11:42:18 -0500 (EST)
Message-ID: <20180206.114218.2137217473788202420.davem@davemloft.net>
References: <4ad95153-e9bf-ef0d-c81a-d8daab2e6d50@gmail.com>
        <20180206.111736.1114727374069829674.davem@davemloft.net>
        <20180206162623.haicwl6s7vjp62ht@yury-thinkpad>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: hkallweit1@gmail.com, akpm@linux-foundation.org,
        sfr@canb.auug.org.au, netdev@vger.kernel.org
To: ynorov@caviumnetworks.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:45770 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752171AbeBFQmU (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 6 Feb 2018 11:42:20 -0500
In-Reply-To: <20180206162623.haicwl6s7vjp62ht@yury-thinkpad>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Yury Norov <ynorov@caviumnetworks.com>
Date: Tue, 6 Feb 2018 19:26:23 +0300

> On Tue, Feb 06, 2018 at 11:17:36AM -0500, David Miller wrote:
>> From: Heiner Kallweit <hkallweit1@gmail.com>
>> Date: Mon, 5 Feb 2018 07:21:32 +0100
>> 
>> > Recently ethtool started to give incomplete values for supported and
>> > advertised modes. There seems to be a regression in this commit:
>> > The bit number parameter in the calls to bitmap_to_arr32() in
>> > store_link_ksettings_for_user() should be __ETHTOOL_LINK_MODE_MASK_NBITS
>> > instead of __ETHTOOL_LINK_MODE_MASK_NU32.
>> > 
>> > After having changed this ethtool behaves normally again.
>> 
>> I do not see the commit with the SHA1 ID from the Subject line in
>> either Linus's nor my networking tree.
>> 
>> Where is that change?
> 
> It's in next-20180202.

Hmmm, then the fix should probably go into whatever tree that commit
ultimately came from.