From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yury Norov Subject: Re: Regression in 39461af74125 "bitmap: replace bitmap_{from,to}_u32array" Date: Tue, 6 Feb 2018 20:03:13 +0300 Message-ID: <20180206170313.2w43v3qmsmlrflxu@yury-thinkpad> References: <4ad95153-e9bf-ef0d-c81a-d8daab2e6d50@gmail.com> <20180206.111736.1114727374069829674.davem@davemloft.net> <20180206162623.haicwl6s7vjp62ht@yury-thinkpad> <20180206.114218.2137217473788202420.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: hkallweit1@gmail.com, akpm@linux-foundation.org, sfr@canb.auug.org.au, netdev@vger.kernel.org To: David Miller Return-path: Received: from mail-by2nam01on0059.outbound.protection.outlook.com ([104.47.34.59]:40896 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753145AbeBFRD1 (ORCPT ); Tue, 6 Feb 2018 12:03:27 -0500 Content-Disposition: inline In-Reply-To: <20180206.114218.2137217473788202420.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Feb 06, 2018 at 11:42:18AM -0500, David Miller wrote: > From: Yury Norov > Date: Tue, 6 Feb 2018 19:26:23 +0300 > > > On Tue, Feb 06, 2018 at 11:17:36AM -0500, David Miller wrote: > >> From: Heiner Kallweit > >> Date: Mon, 5 Feb 2018 07:21:32 +0100 > >> > >> > Recently ethtool started to give incomplete values for supported and > >> > advertised modes. There seems to be a regression in this commit: > >> > The bit number parameter in the calls to bitmap_to_arr32() in > >> > store_link_ksettings_for_user() should be __ETHTOOL_LINK_MODE_MASK_NBITS > >> > instead of __ETHTOOL_LINK_MODE_MASK_NU32. > >> > > >> > After having changed this ethtool behaves normally again. > >> > >> I do not see the commit with the SHA1 ID from the Subject line in > >> either Linus's nor my networking tree. > >> > >> Where is that change? > > > > It's in next-20180202. > > Hmmm, then the fix should probably go into whatever tree that commit > ultimately came from. It's already in Andrew's tree. The original patch is not about networking, and Andrew's tree is probably better place for fix. My apologies for noise in your tree. http://ozlabs.org/~akpm/mmots/broken-out/bitmap-replace-bitmap_fromto_u32array-fix-2.patch