From: "Michael S. Tsirkin" <mst@redhat.com>
To: Greg Kurz <groug@kaod.org>
Cc: v9fs-developer@lists.sourceforge.net,
Latchesar Ionkov <lucho@ionkov.net>,
Eric Van Hensbergen <ericvh@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Ron Minnich <rminnich@sandia.gov>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [V9fs-developer] [PATCH] 9p/trans_virtio: discard zero-length reply
Date: Thu, 8 Feb 2018 21:13:36 +0200 [thread overview]
Message-ID: <20180208211248-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20180208185232.46fca063@bahia.lan>
OK, I've queued it.
On Thu, Feb 08, 2018 at 06:52:32PM +0100, Greg Kurz wrote:
> Ping ?
>
> Michael,
>
> Since this is virtio code and you have acked the QEMU part of the fix already,
> would you be kind enough to take this through your tree ?
>
> Cheers,
>
> --
> Greg
>
> On Mon, 22 Jan 2018 22:02:05 +0100
> Greg Kurz <groug@kaod.org> wrote:
>
> > When a 9p request is successfully flushed, the server is expected to just
> > mark it as used without sending a 9p reply (ie, without writing data into
> > the buffer). In this case, virtqueue_get_buf() will return len == 0 and
> > we must not report a REQ_STATUS_RCVD status to the client, otherwise the
> > client will erroneously assume the request has not been flushed.
> >
> > Signed-off-by: Greg Kurz <groug@kaod.org>
> > ---
> > net/9p/trans_virtio.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/net/9p/trans_virtio.c b/net/9p/trans_virtio.c
> > index 0845aad4ba51..ca08c72ef4de 100644
> > --- a/net/9p/trans_virtio.c
> > +++ b/net/9p/trans_virtio.c
> > @@ -171,7 +171,8 @@ static void req_done(struct virtqueue *vq)
> > spin_unlock_irqrestore(&chan->lock, flags);
> > /* Wakeup if anyone waiting for VirtIO ring space. */
> > wake_up(chan->vc_wq);
> > - p9_client_cb(chan->client, req, REQ_STATUS_RCVD);
> > + if (len)
> > + p9_client_cb(chan->client, req, REQ_STATUS_RCVD);
> > }
> > }
> >
> >
> >
> > ------------------------------------------------------------------------------
> > Check out the vibrant tech community on one of the world's most
> > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> > _______________________________________________
> > V9fs-developer mailing list
> > V9fs-developer@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/v9fs-developer
prev parent reply other threads:[~2018-02-08 19:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 21:02 [PATCH] 9p/trans_virtio: discard zero-length reply Greg Kurz
2018-02-08 17:52 ` [V9fs-developer] " Greg Kurz
2018-02-08 19:13 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180208211248-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=davem@davemloft.net \
--cc=ericvh@gmail.com \
--cc=groug@kaod.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=netdev@vger.kernel.org \
--cc=rminnich@sandia.gov \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).