From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from userp2130.oracle.com ([156.151.31.86]:33698 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750876AbeCPSbx (ORCPT ); Fri, 16 Mar 2018 14:31:53 -0400 Date: Fri, 16 Mar 2018 14:31:33 -0400 From: Sowmini Varadhan To: Kirill Tkhai Cc: santosh.shilimkar@oracle.com, davem@davemloft.net, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, edumazet@google.com Subject: Re: [PATCH RFC RFC] rds: Use NETDEV_UNREGISTER in rds_tcp_dev_event() (then kill NETDEV_UNREGISTER_FINAL) Message-ID: <20180316183133.GP16870@oracle.com> References: <152120385651.2065.2567466917573907029.stgit@localhost.localdomain> <20180316130008.GE16870@oracle.com> <512c2483-aa62-b385-6079-1b6ff8ba4636@virtuozzo.com> <20180316172918.GM16870@oracle.com> <82d6e954-8043-078c-266c-2f1ac992f864@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <82d6e954-8043-078c-266c-2f1ac992f864@virtuozzo.com> Sender: netdev-owner@vger.kernel.org List-ID: On (03/16/18 21:14), Kirill Tkhai wrote: > > I did the second version and sent you. Have you tried it? I tried it briefly, and it works for the handful of testcases that I tried, but I still think its very werid to register as both a device and a subsys, esp in the light of the warning in net_namespace.h Thus I have to spend some time reviewing your patch, and I cannot give you an answer in the next 5 minutes. > Calling netdevice handler for every event is more disturbing, > as number of events is several times bigger, than one more > pernet exit method. So you are saying there are scaling constraints on subsystems that register for netdevice handlers. The disturbing part of that is that it does not scale. Thanks. --Sowmini