netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: andrea.greco.gapmilano@gmail.com
Cc: tobin@apporbit.com, a.greco@4sigma.it,
	m.grzeschik@pengutronix.de, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org
Subject: Re: [PATCH 1/4] arcnet: com20020: Add com20020 io mapped version
Date: Thu, 17 May 2018 16:31:13 -0400 (EDT)	[thread overview]
Message-ID: <20180517.163113.2110198960037727630.davem@davemloft.net> (raw)
In-Reply-To: <20180517130529.2684-1-andrea.greco.gapmilano@gmail.com>

From: Andrea Greco <andrea.greco.gapmilano@gmail.com>
Date: Thu, 17 May 2018 15:05:29 +0200

> +	/* Will be set by userspace during if setup */
> +	dev->dev_addr[0] = 0;

Hmmm... really?

Also, every error path from this point forward will leak 'dev'.

  reply	other threads:[~2018-05-17 20:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-17 13:05 [PATCH 1/4] arcnet: com20020: Add com20020 io mapped version Andrea Greco
2018-05-17 20:31 ` David Miller [this message]
2018-05-18 12:18   ` Andrea Greco
2018-05-18 17:51     ` David Miller
2018-05-22 14:44       ` Andrea Greco
2018-05-20  2:13 ` kbuild test robot
2018-05-20  2:59 ` kbuild test robot
2018-05-20  3:31 ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180517.163113.2110198960037727630.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=a.greco@4sigma.it \
    --cc=andrea.greco.gapmilano@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.grzeschik@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=tobin@apporbit.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).