From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net 1/1] qed: Fix mask for physical address in ILT entry
Date: Tue, 22 May 2018 15:33:54 -0400 (EDT)
Message-ID: <20180522.153354.796330958257215059.davem@davemloft.net>
References: <20180521193147.18628-1-shahed.shaikh@cavium.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, Ariel.Elior@cavium.com,
        Dept-EngEverestLinuxL2@cavium.com
To: shahed.shaikh@cavium.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:46722 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752062AbeEVTdz (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 22 May 2018 15:33:55 -0400
In-Reply-To: <20180521193147.18628-1-shahed.shaikh@cavium.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Shahed Shaikh <shahed.shaikh@cavium.com>
Date: Mon, 21 May 2018 12:31:47 -0700

> ILT entry requires 12 bit right shifted physical address.
> Existing mask for ILT entry of physical address i.e.
> ILT_ENTRY_PHY_ADDR_MASK is not sufficient to handle 64bit
> address because upper 8 bits of 64 bit address were getting
> masked which resulted in completer abort error on
> PCIe bus due to invalid address.
> 
> Fix that mask to handle 64bit physical address.
> 
> Fixes: fe56b9e6a8d9 ("qed: Add module with basic common support")
> 
> Signed-off-by: Shahed Shaikh <shahed.shaikh@cavium.com>
> Signed-off-by: Ariel Elior <ariel.elior@cavium.com>

Please do not put an empty line between Fixes: and other tags in the
future.  I fixed it up this time.

Applied, thanks.