From: David Miller <davem@davemloft.net>
To: toke@toke.dk
Cc: netdev@vger.kernel.org, cake@lists.bufferbloat.net,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH net-next v15 4/7] sch_cake: Add NAT awareness to packet classifier
Date: Wed, 23 May 2018 14:44:42 -0400 (EDT) [thread overview]
Message-ID: <20180523.144442.864194409238516747.davem@davemloft.net> (raw)
In-Reply-To: <152699745846.21931.4558451708304709296.stgit@alrua-kau>
From: Toke Høiland-Jørgensen <toke@toke.dk>
Date: Tue, 22 May 2018 15:57:38 +0200
> When CAKE is deployed on a gateway that also performs NAT (which is a
> common deployment mode), the host fairness mechanism cannot distinguish
> internal hosts from each other, and so fails to work correctly.
>
> To fix this, we add an optional NAT awareness mode, which will query the
> kernel conntrack mechanism to obtain the pre-NAT addresses for each packet
> and use that in the flow and host hashing.
>
> When the shaper is enabled and the host is already performing NAT, the cost
> of this lookup is negligible. However, in unlimited mode with no NAT being
> performed, there is a significant CPU cost at higher bandwidths. For this
> reason, the feature is turned off by default.
>
> Cc: netfilter-devel@vger.kernel.org
> Signed-off-by: Toke Høiland-Jørgensen <toke@toke.dk>
This is really pushing the limits of what a packet scheduler can
require for correct operation. And this creates an incredibly
ugly dependency.
I'd much rather you do something NAT method agnostic, like save
or compute the necessary information on ingress and then later
use it on egress.
Because what you have here will completely break when someone does NAT
using eBPF, act_nat, or similar.
There is even skb->rxhash, be creative :-)
next prev parent reply other threads:[~2018-05-23 18:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 13:57 [PATCH net-next v15 0/7] sched: Add Common Applications Kept Enhanced (cake) qdisc Toke Høiland-Jørgensen
2018-05-22 13:57 ` [PATCH net-next v15 6/7] sch_cake: Add overhead compensation support to the rate shaper Toke Høiland-Jørgensen
2018-05-22 13:57 ` [PATCH net-next v15 3/7] sch_cake: Add optional ACK filter Toke Høiland-Jørgensen
2018-05-22 13:57 ` [PATCH net-next v15 2/7] sch_cake: Add ingress mode Toke Høiland-Jørgensen
2018-05-22 13:57 ` [PATCH net-next v15 5/7] sch_cake: Add DiffServ handling Toke Høiland-Jørgensen
2018-05-22 13:57 ` [PATCH net-next v15 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc Toke Høiland-Jørgensen
2018-05-22 13:57 ` [PATCH net-next v15 4/7] sch_cake: Add NAT awareness to packet classifier Toke Høiland-Jørgensen
2018-05-22 14:07 ` Pablo Neira Ayuso
2018-05-22 14:11 ` Toke Høiland-Jørgensen
2018-05-23 22:46 ` Pablo Neira Ayuso
2018-05-23 23:25 ` Toke Høiland-Jørgensen
2018-05-23 18:44 ` David Miller [this message]
2018-05-23 19:31 ` [Cake] " Jonathan Morton
2018-05-23 20:04 ` David Miller
2018-05-23 20:33 ` Jonathan Morton
2018-05-23 20:39 ` David Miller
2018-05-23 20:38 ` Toke Høiland-Jørgensen
2018-05-23 20:41 ` David Miller
2018-05-23 21:05 ` Toke Høiland-Jørgensen
2018-05-23 21:20 ` David Miller
2018-05-23 22:40 ` Toke Høiland-Jørgensen
2018-05-24 4:52 ` [Cake] " Kevin Darbyshire-Bryant
2018-05-22 13:57 ` [PATCH net-next v15 7/7] sch_cake: Conditionally split GSO segments Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180523.144442.864194409238516747.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cake@lists.bufferbloat.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).