From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH net-next v2] net: sched: don't disable bh when accessing action idr Date: Wed, 23 May 2018 09:32:39 +0200 Message-ID: <20180523073239.GC3155@nanopsycho> References: <20180519.230258.1374885458106197707.davem@davemloft.net> <1526932984-11544-1-git-send-email-vladbu@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: davem@davemloft.net, netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, linux-kernel@vger.kernel.org To: Vlad Buslov Return-path: Content-Disposition: inline In-Reply-To: <1526932984-11544-1-git-send-email-vladbu@mellanox.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Mon, May 21, 2018 at 10:03:04PM CEST, vladbu@mellanox.com wrote: >Initial net_device implementation used ingress_lock spinlock to synchronize >ingress path of device. This lock was used in both process and bh context. >In some code paths action map lock was obtained while holding ingress_lock. >Commit e1e992e52faa ("[NET_SCHED] protect action config/dump from irqs") >modified actions to always disable bh, while using action map lock, in >order to prevent deadlock on ingress_lock in softirq. This lock was removed >from net_device, so disabling bh, while accessing action map, is no longer >necessary. > >Replace all action idr spinlock usage with regular calls that do not >disable bh. > >Signed-off-by: Vlad Buslov Please add my tag to v3, with the description changes requested by Cong. Acked-by: Jiri Pirko Thanks!