From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ilias Apalodimas Subject: Re: [PATCH 0/4] RFC CPSW switchdev mode Date: Thu, 24 May 2018 11:48:31 +0300 Message-ID: <20180524084831.GA2759@apalos> References: <1527144984-31236-1-git-send-email-ilias.apalodimas@linaro.org> <20180524080528.GD2295@nanopsycho> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, grygorii.strashko@ti.com, ivan.khoronzhuk@linaro.org, nsekhar@ti.com, ivecera@redhat.com, francois.ozog@linaro.org, yogeshs@ti.com, spatton@ti.com To: Jiri Pirko Return-path: Received: from mail-wr0-f169.google.com ([209.85.128.169]:44727 "EHLO mail-wr0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965456AbeEXIsg (ORCPT ); Thu, 24 May 2018 04:48:36 -0400 Received: by mail-wr0-f169.google.com with SMTP id y15-v6so1558016wrg.11 for ; Thu, 24 May 2018 01:48:35 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180524080528.GD2295@nanopsycho> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, May 24, 2018 at 10:05:28AM +0200, Jiri Pirko wrote: > Thu, May 24, 2018 at 08:56:20AM CEST, ilias.apalodimas@linaro.org wrote: > Any reason you need cpu port? We don't need it in mlxsw and also in dsa. Yes i've seen that on mlxsw/rocker drivers and i was reluctant adding one here. The reason is that TI wants this configured differently from customer facing ports. Apparently there are existing customers already using the "feature". So OR'ing and adding the cpu port on every operation (add/del vlans add ucast/mcast entries etc) was less favoured. > > What is this device? Could you give me some pointer to description? This is the switch used on TI's AM5728 and BBB boards. I am pretty sure there are other platforms i am not aware of. http://www.ti.com/lit/ug/spruhz6j/spruhz6j.pdf is the techincal reference manual. Section 24.11.5.4 "Initialization and Configuration of CPSW" is the switch part. Thanks, Ilias