From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH rdma-next v3 05/14] IB/uverbs: Add create/destroy counters support Date: Fri, 1 Jun 2018 14:54:36 -0600 Message-ID: <20180601205436.GA20377@ziepe.ca> References: <20180531134341.18441-1-leon@kernel.org> <20180531134341.18441-6-leon@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Doug Ledford , Leon Romanovsky , RDMA mailing list , Boris Pismenny , Matan Barak , "Michael J . Ruhl" , Or Gerlitz , Raed Salem , Yishai Hadas , Saeed Mahameed , linux-netdev To: Leon Romanovsky Return-path: Received: from mail-pg0-f46.google.com ([74.125.83.46]:45584 "EHLO mail-pg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750726AbeFAUyi (ORCPT ); Fri, 1 Jun 2018 16:54:38 -0400 Received: by mail-pg0-f46.google.com with SMTP id z1-v6so4825955pgv.12 for ; Fri, 01 Jun 2018 13:54:37 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180531134341.18441-6-leon@kernel.org> Sender: netdev-owner@vger.kernel.org List-ID: > diff --git a/drivers/infiniband/core/uverbs_std_types_counters.c b/drivers/infiniband/core/uverbs_std_types_counters.c > new file mode 100644 > index 000000000000..a5bc50ceee13 > +++ b/drivers/infiniband/core/uverbs_std_types_counters.c > @@ -0,0 +1,100 @@ > +/* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) */ Check patch tells me this is malformed should be: // SPDX-License-Identifier: GPL-2.0 OR Linux-OpenIB Apparently the WITH Linux-syscall-note is only used in uapi header files. > +/* > + * Copyright (c) 2018, Mellanox Technologies inc. All rights reserved. > + * > + * This software is available to you under a choice of one of two > + * licenses. You may choose to be licensed under the terms of the GNU > + * General Public License (GPL) Version 2, available from the file > + * COPYING in the main directory of this source tree, or the > + * OpenIB.org BSD license below: > + * > + * Redistribution and use in source and binary forms, with or > + * without modification, are permitted provided that the following > + * conditions are met: > + * > + * - Redistributions of source code must retain the above > + * copyright notice, this list of conditions and the following > + * disclaimer. > + * > + * - Redistributions in binary form must reproduce the above > + * copyright notice, this list of conditions and the following > + * disclaimer in the documentation and/or other materials > + * provided with the distribution. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, > + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF > + * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND > + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS > + * BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN > + * ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN > + * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE > + * SOFTWARE. > + */ And this is not a SPDX BSD-2-Clause license, this is the SPDX Linux-OpenIB license. Please be careful to use the correct tag with SPDX.. Also can you check if these SPDX tags are what are intended: include/rdma/restrack.h:/* SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) */ drivers/infiniband/core/restrack.c:/* SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) */ drivers/infiniband/hw/mlx5/ib_rep.c:/* SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) */ drivers/infiniband/hw/mlx5/ib_rep.h:/* SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) */ I'm not super excited about the license proliferation, so if they should have been OR Linux-OpenIB as well then please send a patch. Jason