From: David Miller <davem@davemloft.net>
To: dan.carpenter@oracle.com
Cc: sridhar.samudrala@intel.com, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/2 net-next] net_failover: fix net_failover_compute_features()
Date: Mon, 04 Jun 2018 09:31:47 -0400 (EDT) [thread overview]
Message-ID: <20180604.093147.1707102168081704551.davem@davemloft.net> (raw)
In-Reply-To: <20180531120124.pc4txiifxnrslbei@kili.mountain>
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Thu, 31 May 2018 15:01:25 +0300
> @@ -380,7 +380,8 @@ static rx_handler_result_t net_failover_handle_frame(struct sk_buff **pskb)
>
> static void net_failover_compute_features(struct net_device *dev)
> {
> - u32 vlan_features = FAILOVER_VLAN_FEATURES & NETIF_F_ALL_FOR_ALL;
> + netdev_features_t vlan_features = FAILOVER_VLAN_FEATURES |
> + NETIF_F_ALL_FOR_ALL;
The type does need to be corrected to netdev_features_t, but the
logical operation is correct.
It's a policy operation that was simply by-hand propagated all
over the place where these kinds of calculations are performed.
So vlan_features is starting with a value of 0 intentionally.
next prev parent reply other threads:[~2018-06-04 13:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-31 12:01 [PATCH 1/2 net-next] net_failover: fix net_failover_compute_features() Dan Carpenter
2018-05-31 17:30 ` Samudrala, Sridhar
2018-06-04 13:31 ` David Miller [this message]
2018-06-04 14:43 ` [PATCH 1/2 v2 net-next] net_failover: Use netdev_features_t instead of u32 Dan Carpenter
2018-06-04 21:30 ` David Miller
2018-06-04 14:46 ` [PATCH 2/2 net] team: use " Dan Carpenter
2018-06-04 14:49 ` Jiri Pirko
2018-06-04 21:31 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180604.093147.1707102168081704551.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sridhar.samudrala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).