From: David Miller <davem@davemloft.net>
To: salil.mehta@huawei.com
Cc: yisen.zhuang@huawei.com, lipeng321@huawei.com,
mehta.salil@opnsrc.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linuxarm@huawei.com,
wangxi11@huawei.com
Subject: Re: [PATCH net] net: hns: Fix the process of adding broadcast addresses to tcam
Date: Mon, 04 Jun 2018 11:35:52 -0400 (EDT) [thread overview]
Message-ID: <20180604.113552.1136710379930167373.davem@davemloft.net> (raw)
In-Reply-To: <20180601170011.22700-1-salil.mehta@huawei.com>
From: Salil Mehta <salil.mehta@huawei.com>
Date: Fri, 1 Jun 2018 18:00:11 +0100
> + hns_dsaf_setup_mc_mask(dsaf_dev, mac_entry->in_port_num,
> + mc_mask, mac_entry->addr);
Please indent things properly when arguments span multiple lines.
The second line here should be precisely after the opennning parenthesis
of the previous line.
> + hns_dsaf_setup_mc_mask(dsaf_dev, mac_entry->in_port_num,
> + mc_mask, mac_entry->addr);
Likewise.
next prev parent reply other threads:[~2018-06-04 15:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 17:00 [PATCH net] net: hns: Fix the process of adding broadcast addresses to tcam Salil Mehta
2018-06-04 15:35 ` David Miller [this message]
2018-06-04 15:39 ` Salil Mehta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180604.113552.1136710379930167373.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=lipeng321@huawei.com \
--cc=mehta.salil@opnsrc.net \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=wangxi11@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).