From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next V2 2/2] cls_flower: Fix comparing of old filter mask with new filter Date: Mon, 04 Jun 2018 17:04:15 -0400 (EDT) Message-ID: <20180604.170415.2271439758154626128.davem@davemloft.net> References: <1528009574-63306-1-git-send-email-paulb@mellanox.com> <1528009574-63306-2-git-send-email-paulb@mellanox.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: jiri@mellanox.com, xiyou.wangcong@gmail.com, jhs@mojatatu.com, netdev@vger.kernel.org, kliteyn@mellanox.com, roid@mellanox.com, shahark@mellanox.com, markb@mellanox.com, ogerlitz@mellanox.com To: paulb@mellanox.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:52510 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751086AbeFDVES (ORCPT ); Mon, 4 Jun 2018 17:04:18 -0400 In-Reply-To: <1528009574-63306-2-git-send-email-paulb@mellanox.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Paul Blakey Date: Sun, 3 Jun 2018 10:06:14 +0300 > We incorrectly compare the mask and the result is that we can't modify > an already existing rule. > > Fix that by comparing correctly. > > Fixes: 05cd271fd61a ("cls_flower: Support multiple masks per priority") > Reported-by: Vlad Buslov > Reviewed-by: Roi Dayan > Reviewed-by: Jiri Pirko > Signed-off-by: Paul Blakey Applied.