From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH 0/4] RFC CPSW switchdev mode Date: Tue, 5 Jun 2018 23:28:40 +0200 Message-ID: <20180605212840.GA3796@lunn.ch> References: <1527144984-31236-1-git-send-email-ilias.apalodimas@linaro.org> <20180524080528.GD2295@nanopsycho> <20180524084831.GA2759@apalos> <20180524125431.GB24557@lunn.ch> <7437d485-1eac-9619-3827-5af9b32b939e@redhat.com> <20180524140831.GA16793@apalos> <2b3cabca-4710-0a71-69c7-cc433e2b3062@ti.com> <20180603000831.GA14515@lunn.ch> <327df2cb-a0ad-c272-9b03-066d16ac14b6@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Ilias Apalodimas , Ivan Vecera , Jiri Pirko , netdev@vger.kernel.org, ivan.khoronzhuk@linaro.org, nsekhar@ti.com, francois.ozog@linaro.org, yogeshs@ti.com, spatton@ti.com To: Grygorii Strashko Return-path: Received: from vps0.lunn.ch ([185.16.172.187]:55465 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751849AbeFEV2p (ORCPT ); Tue, 5 Jun 2018 17:28:45 -0400 Content-Disposition: inline In-Reply-To: <327df2cb-a0ad-c272-9b03-066d16ac14b6@ti.com> Sender: netdev-owner@vger.kernel.org List-ID: > I hope you are right - question is always in number of available options > and which one to select - and, most important, explain it to the end user :( The end customer being ptp4linux? At least for Marvell switches, it is happy about everything except that the switch is a bit slow, so we need to modify some of the time outs in the configuration file. > For example: > phc_index is returned as part of .get_ts_info() = cpsw_get_ts_info(), > so which intf should return phc_index? It is not a 1:1 relationship. See: https://elixir.bootlin.com/linux/latest/source/drivers/net/dsa/mv88e6xxx/hwtstamp.c#L61 All interfaces return the same index. In fact, for a switch, having a PHC per port would be odd. That would mean you need to sync the PHCs in order to act as a boundary clock. Andrew