From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH 0/4] RFC CPSW switchdev mode
Date: Wed, 6 Jun 2018 01:49:25 +0200
Message-ID: <20180605234925.GB6237@lunn.ch>
References: <1527144984-31236-1-git-send-email-ilias.apalodimas@linaro.org>
 <20180524080528.GD2295@nanopsycho>
 <20180524084831.GA2759@apalos>
 <20180524125431.GB24557@lunn.ch>
 <7437d485-1eac-9619-3827-5af9b32b939e@redhat.com>
 <20180524140831.GA16793@apalos>
 <2b3cabca-4710-0a71-69c7-cc433e2b3062@ti.com>
 <20180603002618.GB14515@lunn.ch>
 <4908e5f8-7533-6fa5-866f-1fb32fd13857@ti.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>,
        Ivan Vecera <ivecera@redhat.com>,
        Jiri Pirko <jiri@resnulli.us>, netdev@vger.kernel.org,
        ivan.khoronzhuk@linaro.org, nsekhar@ti.com,
        francois.ozog@linaro.org, yogeshs@ti.com, spatton@ti.com
To: Grygorii Strashko <grygorii.strashko@ti.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:55592 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932103AbeFEXt1 (ORCPT <rfc822;netdev@vger.kernel.org>);
        Tue, 5 Jun 2018 19:49:27 -0400
Content-Disposition: inline
In-Reply-To: <4908e5f8-7533-6fa5-866f-1fb32fd13857@ti.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Tue, Jun 05, 2018 at 06:23:45PM -0500, Grygorii Strashko wrote:
> 
> 
> On 06/02/2018 07:26 PM, Andrew Lunn wrote:
> >> *After this patch set*: goal keep things working the same as max as
> >> possible and get rid of TI custom tool.
> > 
> > We are happy to keep things the same, if they fit with the switchdev
> > model. Anything in your customer TI tool/model which does not fit the
> > switchdev model you won't be able to keep, except if we agree to
> > extend the model.
> 
> Right. That's the main goal of RFC to identify those gaps.
> 
> > 
> > I can say now, sw0p0 is going to cause problems. I really do suggest
> > you drop it for the moment in order to get a minimal driver
> > accepted. sw0p0 does not fit the switchdev model.
> 
> Honestly, this is not the first patchset and we started without sw0p0,
> but then.... (with current LKML)
> - default vlan offloading breaks traffic reception to P0
>  (Ilias saying it's fixed in next - good)
> - adding vlan to P1/P2 works, but not for P0 (again as per Ilias -fixed)
> - mcast - no way to manually add static record and include or exclude P0.
> 
> 
> :( above are basic functionality required.

For a DSA driver, this is way more than basic. A basic DSA driver just
provides interfaces, and does everything in software. No offload at
all. Generally, FDB offload is next, then MDB, and then VLAN, each as
separate patch sets.

> Unfortunately, I'm not sure if all this reworking and switchdev conversation would make sense
> if we will not be able to fit Ivan's work in new CPSW driver model ;..(
> and do AVB bridge.

AVB bridge should fit the switchdev model. You can offload TC via
switchdev e.g. the b53 has mirred, mellonex has flower and a lot more.

      Andrew