From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Andrzej Siewior Subject: [PATCH 3/4] isdn: hisax: st5481_usb: use usb_fill_int_urb() Date: Wed, 20 Jun 2018 12:40:27 +0200 Message-ID: <20180620104028.18283-4-bigeasy@linutronix.de> References: <20180620104028.18283-1-bigeasy@linutronix.de> Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Cc: Karsten Keil , linux-usb@vger.kernel.org, tglx@linutronix.de, Sebastian Andrzej Siewior To: netdev@vger.kernel.org Return-path: Received: from Galois.linutronix.de ([146.0.238.70]:59830 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753970AbeFTKmG (ORCPT ); Wed, 20 Jun 2018 06:42:06 -0400 In-Reply-To: <20180620104028.18283-1-bigeasy@linutronix.de> Sender: netdev-owner@vger.kernel.org List-ID: Using usb_fill_int_urb() helps to find code which initializes an URB. A grep for members of the struct (like ->complete) reveal lots of other things, too. Cc: Karsten Keil Cc: netdev@vger.kernel.org Signed-off-by: Sebastian Andrzej Siewior --- drivers/isdn/hisax/st5481_usb.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/isdn/hisax/st5481_usb.c b/drivers/isdn/hisax/st5481_us= b.c index 1cb9930d5e24..f207fda691c7 100644 --- a/drivers/isdn/hisax/st5481_usb.c +++ b/drivers/isdn/hisax/st5481_usb.c @@ -408,15 +408,10 @@ fill_isoc_urb(struct urb *urb, struct usb_device *dev, { int k; =20 - urb->dev =3D dev; - urb->pipe =3D pipe; - urb->interval =3D 1; - urb->transfer_buffer =3D buf; + usb_fill_int_urb(urb, dev, pipe, buf, num_packets * packet_size, + complete, context, 1); + urb->number_of_packets =3D num_packets; - urb->transfer_buffer_length =3D num_packets * packet_size; - urb->actual_length =3D 0; - urb->complete =3D complete; - urb->context =3D context; urb->transfer_flags =3D URB_ISO_ASAP; for (k =3D 0; k < num_packets; k++) { urb->iso_frame_desc[k].offset =3D packet_size * k; --=20 2.17.1