From: Jiri Pirko <jiri@resnulli.us>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, jhs@mojatatu.com, xiyou.wangcong@gmail.com,
jakub.kicinski@netronome.com, simon.horman@netronome.com,
john.hurley@netronome.com, dsahern@gmail.com, mlxsw@mellanox.com,
sridhar.samudrala@intel.com
Subject: [patch net-next v4 08/12] net: sched: cls_flower: propagate chain teplate creation and destruction to drivers
Date: Mon, 23 Jul 2018 09:23:11 +0200 [thread overview]
Message-ID: <20180723072312.4153-9-jiri@resnulli.us> (raw)
In-Reply-To: <20180723072312.4153-1-jiri@resnulli.us>
From: Jiri Pirko <jiri@mellanox.com>
Introduce a couple of flower offload commands in order to propagate
template creation/destruction events down to device drivers.
Drivers may use this information to prepare HW in an optimal way
for future filter insertions.
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
---
v2->v3:
- rebase on top of the reoffload patchset
v1->v2:
- remove leftover extack arg in fl_hw_create_tmplt()
---
include/net/pkt_cls.h | 2 ++
net/sched/cls_flower.c | 39 +++++++++++++++++++++++++++++++++++++++
2 files changed, 41 insertions(+)
diff --git a/include/net/pkt_cls.h b/include/net/pkt_cls.h
index e4252a176eec..7673ee03f093 100644
--- a/include/net/pkt_cls.h
+++ b/include/net/pkt_cls.h
@@ -726,6 +726,8 @@ enum tc_fl_command {
TC_CLSFLOWER_REPLACE,
TC_CLSFLOWER_DESTROY,
TC_CLSFLOWER_STATS,
+ TC_CLSFLOWER_TMPLT_CREATE,
+ TC_CLSFLOWER_TMPLT_DESTROY,
};
struct tc_cls_flower_offload {
diff --git a/net/sched/cls_flower.c b/net/sched/cls_flower.c
index f0c80758a594..6ccf60364297 100644
--- a/net/sched/cls_flower.c
+++ b/net/sched/cls_flower.c
@@ -1194,6 +1194,42 @@ static int fl_reoffload(struct tcf_proto *tp, bool add, tc_setup_cb_t *cb,
return 0;
}
+static void fl_hw_create_tmplt(struct tcf_chain *chain,
+ struct fl_flow_tmplt *tmplt)
+{
+ struct tc_cls_flower_offload cls_flower = {};
+ struct tcf_block *block = chain->block;
+ struct tcf_exts dummy_exts = { 0, };
+
+ cls_flower.common.chain_index = chain->index;
+ cls_flower.command = TC_CLSFLOWER_TMPLT_CREATE;
+ cls_flower.cookie = (unsigned long) tmplt;
+ cls_flower.dissector = &tmplt->dissector;
+ cls_flower.mask = &tmplt->mask;
+ cls_flower.key = &tmplt->dummy_key;
+ cls_flower.exts = &dummy_exts;
+
+ /* We don't care if driver (any of them) fails to handle this
+ * call. It serves just as a hint for it.
+ */
+ tc_setup_cb_call(block, NULL, TC_SETUP_CLSFLOWER,
+ &cls_flower, false);
+}
+
+static void fl_hw_destroy_tmplt(struct tcf_chain *chain,
+ struct fl_flow_tmplt *tmplt)
+{
+ struct tc_cls_flower_offload cls_flower = {};
+ struct tcf_block *block = chain->block;
+
+ cls_flower.common.chain_index = chain->index;
+ cls_flower.command = TC_CLSFLOWER_TMPLT_DESTROY;
+ cls_flower.cookie = (unsigned long) tmplt;
+
+ tc_setup_cb_call(block, NULL, TC_SETUP_CLSFLOWER,
+ &cls_flower, false);
+}
+
static void *fl_tmplt_create(struct net *net, struct tcf_chain *chain,
struct nlattr **tca,
struct netlink_ext_ack *extack)
@@ -1224,6 +1260,8 @@ static void *fl_tmplt_create(struct net *net, struct tcf_chain *chain,
fl_init_dissector(&tmplt->dissector, &tmplt->mask);
+ fl_hw_create_tmplt(chain, tmplt);
+
return tmplt;
errout_tmplt:
@@ -1237,6 +1275,7 @@ static void fl_tmplt_destroy(void *tmplt_priv)
{
struct fl_flow_tmplt *tmplt = tmplt_priv;
+ fl_hw_destroy_tmplt(tmplt->chain, tmplt);
kfree(tmplt);
}
--
2.14.4
next prev parent reply other threads:[~2018-07-23 8:25 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-23 7:23 [patch net-next v4 00/12] sched: introduce chain templates support with offloading to mlxsw Jiri Pirko
2018-07-23 7:23 ` [patch net-next v4 01/12] net: sched: push ops lookup bits into tcf_proto_lookup_ops() Jiri Pirko
2018-07-23 7:23 ` [patch net-next v4 02/12] net: sched: Avoid implicit chain 0 creation Jiri Pirko
2018-07-23 7:23 ` [patch net-next v4 03/12] net: sched: introduce chain object to uapi Jiri Pirko
2018-07-24 22:30 ` Cong Wang
2018-07-24 23:20 ` Cong Wang
2018-07-25 6:46 ` Jiri Pirko
2018-07-25 16:40 ` Cong Wang
2018-07-26 7:38 ` Jiri Pirko
2018-07-26 10:06 ` Jiri Pirko
2018-07-26 12:27 ` Jiri Pirko
2018-07-23 7:23 ` [patch net-next v4 04/12] net: sched: introduce chain templates Jiri Pirko
2018-07-23 7:23 ` [patch net-next v4 05/12] net: sched: cls_flower: move key/mask dumping into a separate function Jiri Pirko
2018-07-23 7:23 ` [patch net-next v4 06/12] net: sched: cls_flower: change fl_init_dissector to accept mask and dissector Jiri Pirko
2018-07-23 7:23 ` [patch net-next v4 07/12] net: sched: cls_flower: implement chain templates Jiri Pirko
2018-07-23 7:23 ` Jiri Pirko [this message]
2018-07-23 7:23 ` [patch net-next v4 09/12] mlxsw: spectrum: Implement chain template hinting Jiri Pirko
2018-07-23 7:24 ` [patch net-next v4 10/12] selftests: forwarding: move shblock tc support check to a separate helper Jiri Pirko
2018-07-23 7:24 ` [patch net-next v4 11/12] selftests: forwarding: add tests for TC chains creation adn destruction Jiri Pirko
2018-07-23 7:24 ` [patch net-next v4 12/12] selftests: forwarding: add tests for TC chain templates Jiri Pirko
2018-07-23 7:24 ` [patch iproute2/net-next v4] tc: introduce support for " Jiri Pirko
2018-07-25 17:03 ` David Ahern
2018-07-23 16:28 ` [patch net-next v4 00/12] sched: introduce chain templates support with offloading to mlxsw David Miller
2018-07-23 23:36 ` Jakub Kicinski
2018-07-24 3:45 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180723072312.4153-9-jiri@resnulli.us \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=jhs@mojatatu.com \
--cc=john.hurley@netronome.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=simon.horman@netronome.com \
--cc=sridhar.samudrala@intel.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).