From: David Miller <davem@davemloft.net>
To: dima@arista.com
Cc: natechancellor@gmail.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
herbert@gondor.apana.org.au, steffen.klassert@secunet.com,
netdev@vger.kernel.org
Subject: Re: [PATCH 4.4 106/124] netlink: Do not subscribe to non-existent groups
Date: Sat, 04 Aug 2018 16:33:48 -0700 (PDT) [thread overview]
Message-ID: <20180804.163348.896647113172060665.davem@davemloft.net> (raw)
In-Reply-To: <1533425198.2679.148.camel@arista.com>
From: Dmitry Safonov <dima@arista.com>
Date: Sun, 05 Aug 2018 00:26:38 +0100
> Thanks for the testing, sorry again for the breakage.
> Will send the patch shortly (with sizeof(unsigned long long) instead of
> hard-coded 64). Hopefully, not too late.
'groups' is "long unsigned int" not "unsigned long long"
long unsigned int groups = nladdr->nl_groups;
And nladdr->nl_groups is specified as "__u32"
So the size of the relevant bits is actually strictly 32-bit.
This makes also the "ULL" in your constant specification incorrect as
well.
So much crazy stuff going on here :-/
next prev parent reply other threads:[~2018-08-04 23:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180804082702.434482435@linuxfoundation.org>
2018-08-04 9:01 ` [PATCH 4.4 106/124] netlink: Do not subscribe to non-existent groups Greg Kroah-Hartman
2018-08-04 18:07 ` Nathan Chancellor
2018-08-04 22:33 ` Dmitry Safonov
2018-08-04 22:49 ` Nathan Chancellor
2018-08-04 23:12 ` Dmitry Safonov
2018-08-04 23:21 ` Nathan Chancellor
2018-08-04 23:25 ` David Miller
2018-08-04 23:26 ` Dmitry Safonov
2018-08-04 23:33 ` David Miller [this message]
2018-08-04 23:44 ` Dmitry Safonov
2018-08-04 23:50 ` Dmitry Safonov
2018-08-05 0:07 ` David Miller
2018-08-04 23:47 ` Dmitry Safonov
2018-08-05 0:08 ` David Miller
2018-08-05 14:03 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180804.163348.896647113172060665.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dima@arista.com \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).