From: David Miller <davem@davemloft.net>
To: joyce.ooi@intel.com
Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com,
joabreu@synopsys.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, hean.loong.ong@intel.com,
yves.vandervennet@intel.com
Subject: Re: [PATCH] net: stmmac: Add SMC support for EMAC System Manager register
Date: Mon, 13 Aug 2018 09:48:06 -0700 (PDT) [thread overview]
Message-ID: <20180813.094806.2117966073798365808.davem@davemloft.net> (raw)
In-Reply-To: <1534142494-11541-1-git-send-email-joyce.ooi@intel.com>
From: "Ooi, Joyce" <joyce.ooi@intel.com>
Date: Sun, 12 Aug 2018 23:41:34 -0700
> As there is restriction to access to EMAC System Manager registers in
> the kernel for Intel Stratix10, the use of SMC calls are required and
> added in dwmac-socfpga driver.
>
> Signed-off-by: Ooi, Joyce <joyce.ooi@intel.com>
> ---
> This patch is dependent on https://lkml.org/lkml/2018/7/26/624
I guess I cannot apply this to my networking tree then.
I would suggest that you make a helper in a header file which dos the
special SMC EMAC accesses, or alternatively the regular regmap access,
based upon the CPP ifdef.
That way you won't have to put all of those CPP tests in the foo.c
code.
Thanks.
next prev parent reply other threads:[~2018-08-13 16:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-13 6:41 [PATCH] net: stmmac: Add SMC support for EMAC System Manager register Ooi, Joyce
2018-08-13 16:48 ` David Miller [this message]
2018-08-16 3:39 ` Ooi, Joyce
2018-08-13 21:41 ` kbuild test robot
2019-02-12 16:24 Ooi, Joyce
2019-02-12 20:52 ` Thor Thayer
2019-02-13 3:22 ` Ooi, Joyce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180813.094806.2117966073798365808.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexandre.torgue@st.com \
--cc=hean.loong.ong@intel.com \
--cc=joabreu@synopsys.com \
--cc=joyce.ooi@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=yves.vandervennet@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).