From: David Miller <davem@davemloft.net>
To: makita.toshiaki@lab.ntt.co.jp
Cc: netdev@vger.kernel.org, brouer@redhat.com
Subject: Re: [PATCH net-next 0/3] veth: XDP stats improvement
Date: Mon, 15 Oct 2018 21:58:58 -0700 (PDT) [thread overview]
Message-ID: <20181015.215858.739156373795267540.davem@davemloft.net> (raw)
In-Reply-To: <1539250610-2557-1-git-send-email-makita.toshiaki@lab.ntt.co.jp>
From: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
Date: Thu, 11 Oct 2018 18:36:47 +0900
> ndo_xdp_xmit in veth did not update packet counters as described in [1].
> Also, current implementation only updates counters on tx side so rx side
> events like XDP_DROP were not collected.
> This series implements the missing accounting as well as support for
> ethtool per-queue stats in veth.
>
> Patch 1: Update drop counter in ndo_xdp_xmit.
> Patch 2: Update packet and byte counters for all XDP path, and drop
> counter on XDP_DROP.
> Patch 3: Support per-queue ethtool stats for XDP counters.
>
> Note that counters are maintained on per-queue basis for XDP but not
> otherwise (per-cpu and atomic as before). This is because 1) tx path in
> veth is essentially lockless so we cannot update per-queue stats on tx,
> and 2) rx path is net core routine (process_backlog) which cannot update
> per-queue based stats when XDP is disabled. On the other hand there are
> real rxqs and napi handlers for veth XDP, so update per-queue stats on
> rx for XDP packets, and use them to calculate tx counters as well,
> contrary to the existing non-XDP counters.
>
> [1] https://patchwork.ozlabs.org/cover/953071/#1967449
>
> Signed-off-by: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
Series applied.
prev parent reply other threads:[~2018-10-16 12:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-11 9:36 [PATCH net-next 0/3] veth: XDP stats improvement Toshiaki Makita
2018-10-11 9:36 ` [PATCH net-next 1/3] veth: Account for packet drops in ndo_xdp_xmit Toshiaki Makita
2018-10-13 7:48 ` Jesper Dangaard Brouer
2018-10-13 8:57 ` Toshiaki Makita
2018-10-11 9:36 ` [PATCH net-next 2/3] veth: Account for XDP packet statistics on rx side Toshiaki Makita
2018-10-11 9:36 ` [PATCH net-next 3/3] veth: Add ethtool statistics support for XDP Toshiaki Makita
2018-10-16 4:58 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181015.215858.739156373795267540.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=brouer@redhat.com \
--cc=makita.toshiaki@lab.ntt.co.jp \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).