From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ivan Khoronzhuk Subject: Re: [RFC PATCH net-next 0/4] net: ethernet: ti: cpsw: fix vlan mcast Date: Wed, 17 Oct 2018 23:11:35 +0300 Message-ID: <20181017201133.GA13816@khorivan> References: <20181016182035.18234-1-ivan.khoronzhuk@linaro.org> <92ab4728-109f-01cc-09db-3da4d8c8e92e@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Cc: davem@davemloft.net, linux-omap@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, alexander.h.duyck@intel.com To: Grygorii Strashko Return-path: Received: from mail-lf1-f66.google.com ([209.85.167.66]:33079 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725798AbeJREI6 (ORCPT ); Thu, 18 Oct 2018 00:08:58 -0400 Received: by mail-lf1-f66.google.com with SMTP id o21-v6so20835302lfe.0 for ; Wed, 17 Oct 2018 13:11:39 -0700 (PDT) Content-Disposition: inline In-Reply-To: <92ab4728-109f-01cc-09db-3da4d8c8e92e@ti.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Oct 16, 2018 at 02:38:33PM -0500, Grygorii Strashko wrote: > > >On 10/16/2018 01:20 PM, Ivan Khoronzhuk wrote: >>The cpsw holds separate mcast entires for vlan entries. At this moment >>driver adds only not vlan mcast addresses, omitting vlan/mcast entries. >>As result mcast for vlans doesn't work. It can be fixed by adding same >>mcast entries for every created vlan, but this patchseries uses more >>sophisticated way and allows to create mcast entries only for vlans >>that really require it. Generic functions from this series can be >>reused for fixing vlan and macvlan unicast. > >I assume this is first of all for dual_mac mode. Mainly yes, but affects on switch mode also (and single port) adding appropriate mcast entries. -- Regards, Ivan Khoronzhuk