From: David Miller <davem@davemloft.net>
To: gqjiang@suse.com
Cc: jon.maloy@ericsson.com, ying.xue@windriver.com,
netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net
Subject: Re: [PATCH] tipc: use destination length for copy string
Date: Mon, 22 Oct 2018 19:25:58 -0700 (PDT) [thread overview]
Message-ID: <20181022.192558.1512536195523667509.davem@davemloft.net> (raw)
In-Reply-To: <20181019040822.15961-1-gqjiang@suse.com>
From: Guoqing Jiang <gqjiang@suse.com>
Date: Fri, 19 Oct 2018 12:08:22 +0800
> Got below warning with gcc 8.2 compiler.
>
> net/tipc/topsrv.c: In function ‘tipc_topsrv_start’:
> net/tipc/topsrv.c:660:2: warning: ‘strncpy’ specified bound depends on the length of the source argument [-Wstringop-overflow=]
> strncpy(srv->name, name, strlen(name) + 1);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> net/tipc/topsrv.c:660:27: note: length computed here
> strncpy(srv->name, name, strlen(name) + 1);
> ^~~~~~~~~~~~
> So change it to correct length and use strscpy.
>
> Signed-off-by: Guoqing Jiang <gqjiang@suse.com>
Applied.
prev parent reply other threads:[~2018-10-23 10:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-19 4:08 [PATCH] tipc: use destination length for copy string Guoqing Jiang
2018-10-19 4:31 ` Ying Xue
2018-10-23 2:25 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181022.192558.1512536195523667509.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gqjiang@suse.com \
--cc=jon.maloy@ericsson.com \
--cc=netdev@vger.kernel.org \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).