From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next 3/4] net: phy-c45: Implement
 reset/suspend/resume callbacks
Date: Mon, 22 Oct 2018 14:28:39 +0200
Message-ID: <20181022122839.GB24112@lunn.ch>
References: <cover.1540204182.git.joabreu@synopsys.com>
 <b65cd0978587224eb1496ad60d224394525b8ba6.1540204183.git.joabreu@synopsys.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: netdev@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Joao Pinto <joao.pinto@synopsys.com>
To: Jose Abreu <jose.abreu@synopsys.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:40132 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1727702AbeJVUrF (ORCPT <rfc822;netdev@vger.kernel.org>);
        Mon, 22 Oct 2018 16:47:05 -0400
Content-Disposition: inline
In-Reply-To: <b65cd0978587224eb1496ad60d224394525b8ba6.1540204183.git.joabreu@synopsys.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

>  EXPORT_SYMBOL_GPL(gen10g_resume);
> @@ -327,7 +381,7 @@ struct phy_driver genphy_10g_driver = {
>  	.phy_id         = 0xffffffff,
>  	.phy_id_mask    = 0xffffffff,
>  	.name           = "Generic 10G PHY",
> -	.soft_reset	= gen10g_no_soft_reset,
> +	.soft_reset	= gen10g_soft_reset,
>  	.config_init    = gen10g_config_init,
>  	.features       = 0,
>  	.aneg_done	= genphy_c45_aneg_done,

Hi Jose

You need to be careful here. There is a reason this is called
gen10g_no_soft_reset, rather than having an empty
gen10g_soft_reset. Some PHYs break when you do a reset.  So adding a
gen10g_soft_reset is fine, but don't change this here, without first
understanding the history, and talking to Russell King.

	      Andrew