netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sagi Grimberg <sagi@grimberg.me>
To: linux-nvme@lists.infradead.org
Cc: linux-block@vger.kernel.org, netdev@vger.kernel.org,
	Christoph Hellwig <hch@lst.de>,
	Keith Busch <keith.busch@intel.com>,
	"David S. Miller" <davem@davemloft.net>
Subject: [PATCH v4 07/13] nvmet: Add install_queue callout
Date: Tue, 27 Nov 2018 15:16:09 -0800	[thread overview]
Message-ID: <20181127231615.9446-8-sagi@grimberg.me> (raw)
In-Reply-To: <20181127231615.9446-1-sagi@grimberg.me>

From: Sagi Grimberg <sagi@lightbitslabs.com>

nvmet-tcp will implement it to allocate queue commands which
are only known at nvmf connect time (sq size).

Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Sagi Grimberg <sagi@lightbitslabs.com>
---
 drivers/nvme/target/fabrics-cmd.c | 10 ++++++++++
 drivers/nvme/target/nvmet.h       |  1 +
 2 files changed, 11 insertions(+)

diff --git a/drivers/nvme/target/fabrics-cmd.c b/drivers/nvme/target/fabrics-cmd.c
index 328ae46d8344..ee7d84621d65 100644
--- a/drivers/nvme/target/fabrics-cmd.c
+++ b/drivers/nvme/target/fabrics-cmd.c
@@ -121,6 +121,16 @@ static u16 nvmet_install_queue(struct nvmet_ctrl *ctrl, struct nvmet_req *req)
 		req->rsp->sq_head = cpu_to_le16(0xffff);
 	}
 
+	if (ctrl->ops->install_queue) {
+		u16 ret = ctrl->ops->install_queue(req->sq);
+
+		if (ret) {
+			pr_err("failed to install queue %d cntlid %d ret %x\n",
+				qid, ret, ctrl->cntlid);
+			return ret;
+		}
+	}
+
 	return 0;
 }
 
diff --git a/drivers/nvme/target/nvmet.h b/drivers/nvme/target/nvmet.h
index 7d8b7a7d572a..89df51ee5bdf 100644
--- a/drivers/nvme/target/nvmet.h
+++ b/drivers/nvme/target/nvmet.h
@@ -279,6 +279,7 @@ struct nvmet_fabrics_ops {
 	void (*delete_ctrl)(struct nvmet_ctrl *ctrl);
 	void (*disc_traddr)(struct nvmet_req *req,
 			struct nvmet_port *port, char *traddr);
+	u16 (*install_queue)(struct nvmet_sq *nvme_sq);
 };
 
 #define NVMET_MAX_INLINE_BIOVEC	8
-- 
2.17.1

  parent reply	other threads:[~2018-11-28 10:15 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-27 23:16 [PATCH v4 00/13] TCP transport binding for NVMe over Fabrics Sagi Grimberg
2018-11-27 23:16 ` [PATCH v4 01/13] ath6kl: add ath6kl_ prefix to crypto_type Sagi Grimberg
2018-11-27 23:16 ` [PATCH v4 02/13] datagram: open-code copy_page_to_iter Sagi Grimberg
2018-11-27 23:16 ` [PATCH v4 03/13] iov_iter: pass void csum pointer to csum_and_copy_to_iter Sagi Grimberg
2018-11-27 23:16 ` [PATCH v4 04/13] datagram: consolidate datagram copy to iter helpers Sagi Grimberg
2018-11-27 23:16 ` [PATCH v4 05/13] iov_iter: introduce hash_and_copy_to_iter helper Sagi Grimberg
2018-11-27 23:16 ` [PATCH v4 06/13] datagram: introduce skb_copy_and_hash_datagram_iter helper Sagi Grimberg
2018-11-27 23:16 ` Sagi Grimberg [this message]
2018-11-27 23:16 ` [PATCH v4 08/13] nvme-fabrics: allow user passing header digest Sagi Grimberg
2018-11-27 23:16 ` [PATCH v4 09/13] nvme-fabrics: allow user passing data digest Sagi Grimberg
2018-11-27 23:16 ` [PATCH v4 10/13] nvme-tcp: Add protocol header Sagi Grimberg
2018-11-27 23:16 ` [PATCH v4 11/13] nvmet-tcp: add NVMe over TCP target driver Sagi Grimberg
2018-11-29  0:16   ` Max Gurtovoy
2018-11-30  1:22     ` Sagi Grimberg
2018-11-27 23:16 ` [PATCH v4 12/13] nvmet: allow configfs tcp trtype configuration Sagi Grimberg
2018-11-27 23:16 ` [PATCH v4 13/13] nvme-tcp: add NVMe over TCP host driver Sagi Grimberg
2018-11-28  7:01 ` [PATCH v4 00/13] TCP transport binding for NVMe over Fabrics Christoph Hellwig
2018-11-30  1:24   ` Sagi Grimberg
2018-11-30  2:14     ` David Miller
2018-11-30 20:37       ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181127231615.9446-8-sagi@grimberg.me \
    --to=sagi@grimberg.me \
    --cc=davem@davemloft.net \
    --cc=hch@lst.de \
    --cc=keith.busch@intel.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).