From: David Miller <davem@davemloft.net>
To: ivecera@redhat.com
Cc: poros@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH net] be2net: Fix NULL pointer dereference in be_tx_timeout()
Date: Wed, 28 Nov 2018 11:32:02 -0800 (PST) [thread overview]
Message-ID: <20181128.113202.2188317411211917251.davem@davemloft.net> (raw)
In-Reply-To: <d2aebf72-d3d7-7d8e-d570-c4a487a50623@redhat.com>
From: Ivan Vecera <ivecera@redhat.com>
Date: Wed, 28 Nov 2018 20:29:44 +0100
> And the right way? netif_device_detach() that does not fire
> linkwatch events?
Allocate all the TX queue resources first.
Do not modify the TX queue configuration in any way whatsoever
meanwhile.
Only after successfully allocating the resources, should you
commit them to the hardware configuration.
That way there is no problem and you don't have to worry about
the OOPS in question.
prev parent reply other threads:[~2018-11-29 6:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-22 14:24 [PATCH net] be2net: Fix NULL pointer dereference in be_tx_timeout() Petr Oros
2018-11-27 22:51 ` David Miller
2018-11-28 10:12 ` Ivan Vecera
2018-11-28 19:00 ` David Miller
2018-11-28 19:29 ` Ivan Vecera
2018-11-28 19:32 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181128.113202.2188317411211917251.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ivecera@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=poros@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).