From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH] mv88e6060: Warn about errors
Date: Thu, 06 Dec 2018 12:21:59 -0800 (PST)
Message-ID: <20181206.122159.185940398402192249.davem@davemloft.net>
References: <20181115195111.GA9946@amd>
        <20181206130051.GA22343@amd>
        <20181206130145.GB22343@amd>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: andrew@lunn.ch, vivien.didelot@savoirfairelinux.com,
        netdev@vger.kernel.org, f.fainelli@gmail.com, buytenh@marvell.com,
        buytenh@wantstofly.org, nico@marvell.com
To: pavel@ucw.cz
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([23.128.96.9]:40482 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726034AbeLFUWB (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 6 Dec 2018 15:22:01 -0500
In-Reply-To: <20181206130145.GB22343@amd>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>


Plain "printk" are never appropriate.

Please explicitly use pr_warn() or similar.  If there is a device context
available, either a generic device or a netdev, use one of the dev_*()
or netdev_*() variants.