From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH net-next,v5 01/12] flow_offload: add flow_rule and flow_match structures and use them Date: Sat, 8 Dec 2018 09:27:59 +0100 Message-ID: <20181208082759.GA2581@nanopsycho.orion> References: <20181206224002.5109-1-pablo@netfilter.org> <20181206224002.5109-2-pablo@netfilter.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, davem@davemloft.net, thomas.lendacky@amd.com, f.fainelli@gmail.com, ariel.elior@cavium.com, michael.chan@broadcom.com, santosh@chelsio.com, madalin.bucur@nxp.com, yisen.zhuang@huawei.com, salil.mehta@huawei.com, jeffrey.t.kirsher@intel.com, tariqt@mellanox.com, saeedm@mellanox.com, jiri@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, peppe.cavallaro@st.com, grygorii.strashko@ti.com, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, alexandre.torgue@st.com, joabreu@synopsys.com, linux-net-drivers@solarflare.com, ganeshgr@chelsio.com, ogerlitz@mellanox.com, Manish.Chopra@cavium.com, marcelo.leitner@gmail.com, mkubecek@suse.cz, venkatkumar.duvvuru@broadcom.com, julia.lawall@lip6.fr, john.fastabend@gmail.com To: Pablo Neira Ayuso Return-path: Received: from mail-wm1-f65.google.com ([209.85.128.65]:34242 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726103AbeLHIfP (ORCPT ); Sat, 8 Dec 2018 03:35:15 -0500 Received: by mail-wm1-f65.google.com with SMTP id y185so2838561wmd.1 for ; Sat, 08 Dec 2018 00:35:14 -0800 (PST) Content-Disposition: inline In-Reply-To: <20181206224002.5109-2-pablo@netfilter.org> Sender: netdev-owner@vger.kernel.org List-ID: Thu, Dec 06, 2018 at 11:39:51PM CET, pablo@netfilter.org wrote: >This patch wraps the dissector key and mask - that flower uses to >represent the matching side - around the flow_match structure. > >To avoid a follow up patch that would edit the same LoCs in the drivers, >this patch also wraps this new flow match structure around the flow rule >object. This new structure will also contain the flow actions in follow >up patches. > >This introduces two new interfaces: > > bool flow_rule_match_key(rule, dissector_id) > >that returns true if a given matching key is set on, and: > > flow_rule_match_XYZ(rule, &match); > >To fetch the matching side XYZ into the match container structure, to >retrieve the key and the mask with one single call. > >Signed-off-by: Pablo Neira Ayuso Acked-by: Jiri Pirko