From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: Or Gerlitz <gerlitz.or@gmail.com>,
David Miller <davem@davemloft.net>,
Florian Westphal <fw@strlen.de>,
Linux Netdev List <netdev@vger.kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Jiri Pirko <jiri@mellanox.com>,
mkubecek@suse.cz, Jamal Hadi Salim <jhs@mojatatu.com>
Subject: Re: [net-next,v5,00/12] add flow_rule infrastructure
Date: Thu, 13 Dec 2018 20:54:39 +0100 [thread overview]
Message-ID: <20181213195439.dn7wt2mlfoo5dkpw@salvia> (raw)
In-Reply-To: <20181213112315.7ea76799@cakuba.netronome.com>
On Thu, Dec 13, 2018 at 11:23:15AM -0800, Jakub Kicinski wrote:
> On Thu, 13 Dec 2018 12:06:39 +0200, Or Gerlitz wrote:
> > > Maybe having a side library that could take a ethtool/flower/nft flow
> > > and return common IR representation of that flow would be less painful?
> > > Drivers could then migrate at its own pace, for new functionality etc.
> > > Was that discussed before? I may have lost track of this discussion...
> >
> > Currently all drivers are ported to use the IR on the tc/flower offload path
> >
> > End of the day, seems that Jiri and Jakub are good with this and I didn't hear
> > any further rejections from other driver folks, so I guess my concerns
> > were basically addressed by them.
>
> I think having the drivers call the IR translation could be a good
> compromise instead of having flower always pass down converted flows.
>
> tc flower -> flower offload object -> setup_tc -> driver ->
> -> flow_offload_from_flower() -> driver -> driver's common handling
>
> This patchset already does that for ethtool:
>
> ethtool -> ethtool flow -> ethtool_op -> driver ->
> -> ethtool_rx_flow_rule_create() -> driver -> driver's common handling
>
> It feels like a bit of a waste to let the driver patches go, but
> perhaps it's a good way to move forward?
I think Michal Kubecek mentioned that it would be good if, moving
forward, core/ethtool.c calls ethtool_rx_flow_rule_create(), so this is:
ethtool -> ethtool flow -> ethtool_rx_flow_rule_create() ->
-> ethtool_op -> driver -> driver's common handling
In that case, ethtool would match what flower is doing.
We can probably offer the flow_rule representation as parameter via
ethtool_op indirection, so there is a single ethtool_rx_flow_rule_create()
call. Still, this new infrastructure is used by two ethtool drivers,
so probably it is too early for this consolidation work.
next prev parent reply other threads:[~2018-12-13 19:54 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 22:39 [PATCH net-next,v5 00/12] add flow_rule infrastructure Pablo Neira Ayuso
2018-12-06 22:39 ` [PATCH net-next,v5 01/12] flow_offload: add flow_rule and flow_match structures and use them Pablo Neira Ayuso
2018-12-08 8:27 ` Jiri Pirko
2018-12-06 22:39 ` [PATCH net-next,v5 02/12] net/mlx5e: support for two independent packet edit actions Pablo Neira Ayuso
2018-12-08 8:49 ` Jiri Pirko
2018-12-06 22:39 ` [PATCH net-next,v5 03/12] flow_offload: add flow action infrastructure Pablo Neira Ayuso
2018-12-08 8:49 ` Jiri Pirko
2018-12-06 22:39 ` [PATCH net-next,v5 04/12] cls_api: add translator to flow_action representation Pablo Neira Ayuso
2018-12-08 8:49 ` Jiri Pirko
2018-12-06 22:39 ` [PATCH net-next,v5 05/12] flow_offload: add statistics retrieval infrastructure and use it Pablo Neira Ayuso
2018-12-08 12:56 ` Jiri Pirko
2018-12-06 22:39 ` [PATCH net-next,v5 06/12] drivers: net: use flow action infrastructure Pablo Neira Ayuso
2018-12-08 12:59 ` Jiri Pirko
2018-12-06 22:39 ` [PATCH net-next,v5 07/12] cls_flower: don't expose TC actions to drivers anymore Pablo Neira Ayuso
2018-12-08 12:57 ` Jiri Pirko
2018-12-06 22:39 ` [PATCH net-next,v5 08/12] flow_offload: add wake-up-on-lan and queue to flow_action Pablo Neira Ayuso
2018-12-08 13:12 ` Jiri Pirko
2018-12-06 22:39 ` [PATCH net-next,v5 09/12] ethtool: add ethtool_rx_flow_spec to flow_rule structure translator Pablo Neira Ayuso
2018-12-08 13:14 ` Jiri Pirko
2018-12-06 22:40 ` [PATCH net-next,v5 10/12] dsa: bcm_sf2: use flow_rule infrastructure Pablo Neira Ayuso
2018-12-08 17:22 ` Jiri Pirko
2018-12-06 22:40 ` [PATCH net-next,v5 11/12] qede: place ethtool_rx_flow_spec after code after TC flower codebase Pablo Neira Ayuso
2018-12-08 17:22 ` Jiri Pirko
2018-12-06 22:40 ` [PATCH net-next,v5 12/12] qede: use ethtool_rx_flow_rule() to remove duplicated parser code Pablo Neira Ayuso
2018-12-11 15:35 ` [net-next,v5,00/12] add flow_rule infrastructure Florian Westphal
2018-12-11 19:14 ` David Miller
2018-12-11 20:59 ` Or Gerlitz
2018-12-11 22:17 ` Jakub Kicinski
2018-12-13 10:06 ` Or Gerlitz
2018-12-13 19:23 ` Jakub Kicinski
2018-12-13 19:54 ` Pablo Neira Ayuso [this message]
2018-12-13 20:17 ` Michal Kubecek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213195439.dn7wt2mlfoo5dkpw@salvia \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=fw@strlen.de \
--cc=gerlitz.or@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=jhs@mojatatu.com \
--cc=jiri@mellanox.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).