From: "Björn Töpel" <bjorn.topel@gmail.com>
To: bjorn.topel@gmail.com, magnus.karlsson@intel.com,
magnus.karlsson@gmail.com, ast@kernel.org, daniel@iogearbox.net,
netdev@vger.kernel.org
Cc: "Björn Töpel" <bjorn.topel@intel.com>,
brouer@redhat.com, u9012063@gmail.com, qi.z.zhang@intel.com,
jakub.kicinski@netronome.com, andrew@lunn.ch
Subject: [PATCH bpf-next v2 6/7] samples: bpf: simplify/cleanup xdpsock
Date: Mon, 17 Dec 2018 11:25:00 +0100 [thread overview]
Message-ID: <20181217102501.22019-7-bjorn.topel@gmail.com> (raw)
In-Reply-To: <20181217102501.22019-1-bjorn.topel@gmail.com>
From: Björn Töpel <bjorn.topel@intel.com>
Break out all map and XDP program setup into a function.
Signed-off-by: Björn Töpel <bjorn.topel@intel.com>
---
samples/bpf/xdpsock_user.c | 91 +++++++++++++++++++++-----------------
1 file changed, 50 insertions(+), 41 deletions(-)
diff --git a/samples/bpf/xdpsock_user.c b/samples/bpf/xdpsock_user.c
index 57ecadc58403..c72face0da05 100644
--- a/samples/bpf/xdpsock_user.c
+++ b/samples/bpf/xdpsock_user.c
@@ -119,7 +119,7 @@ struct xdpsock {
};
static int num_socks;
-struct xdpsock *xsks[MAX_SOCKS];
+static struct xdpsock *xsks[MAX_SOCKS];
static unsigned long get_nsecs(void)
{
@@ -897,37 +897,21 @@ static void l2fwd(struct xdpsock *xsk)
}
}
-int main(int argc, char **argv)
+static void setup_xdp_xskmap(const char *pathprefix)
{
- struct rlimit r = {RLIM_INFINITY, RLIM_INFINITY};
- struct bpf_prog_load_attr prog_load_attr = {
- .prog_type = BPF_PROG_TYPE_XDP,
- };
- int prog_fd, qidconf_map, xsks_map;
+ int prog_fd, qidconf_map, xsks_map, i, key = 0, err;
+ struct bpf_prog_load_attr prog_load_attr = {};
+ char bpf_objs_filename[256];
+ struct bpf_program *prog;
struct bpf_object *obj;
- char xdp_filename[256];
struct bpf_map *map;
- int i, ret, key = 0;
- pthread_t pt;
- parse_command_line(argc, argv);
-
- if (setrlimit(RLIMIT_MEMLOCK, &r)) {
- fprintf(stderr, "ERROR: setrlimit(RLIMIT_MEMLOCK) \"%s\"\n",
- strerror(errno));
- exit(EXIT_FAILURE);
- }
-
- snprintf(xdp_filename, sizeof(xdp_filename), "%s_kern.o", argv[0]);
- prog_load_attr.file = xdp_filename;
+ snprintf(bpf_objs_filename, sizeof(bpf_objs_filename), "%s_kern.o",
+ pathprefix);
+ prog_load_attr.file = bpf_objs_filename;
if (bpf_prog_load_xattr(&prog_load_attr, &obj, &prog_fd))
exit(EXIT_FAILURE);
- if (prog_fd < 0) {
- fprintf(stderr, "ERROR: no program found: %s\n",
- strerror(prog_fd));
- exit(EXIT_FAILURE);
- }
map = bpf_object__find_map_by_name(obj, "qidconf_map");
qidconf_map = bpf_map__fd(map);
@@ -945,14 +929,51 @@ int main(int argc, char **argv)
exit(EXIT_FAILURE);
}
+ err = bpf_map_update_elem(qidconf_map, &key, &opt_queue, 0);
+ if (err) {
+ fprintf(stderr, "ERROR: bpf_map_update_elem qidconf\n");
+ exit(EXIT_FAILURE);
+ }
+
+ /* Insert sockets into into the XSKMAP. */
+ for (i = 0; i < num_socks; i++) {
+ key = i;
+ err = bpf_map_update_elem(xsks_map, &key, &xsks[i]->sfd, 0);
+ if (err) {
+ fprintf(stderr, "ERROR: bpf_map_update_elem %d\n", i);
+ exit(EXIT_FAILURE);
+ }
+ }
+
+ prog = bpf_object__find_program_by_title(obj, "xdp_sock");
+ prog_fd = bpf_program__fd(prog);
+ if (prog_fd < 0) {
+ fprintf(stderr, "ERROR: no xdp_sock program found: %s\n",
+ strerror(prog_fd));
+ exit(EXIT_FAILURE);
+ }
+
if (bpf_set_link_xdp_fd(opt_ifindex, prog_fd, opt_xdp_flags) < 0) {
fprintf(stderr, "ERROR: link set xdp fd failed\n");
exit(EXIT_FAILURE);
}
+}
- ret = bpf_map_update_elem(qidconf_map, &key, &opt_queue, 0);
- if (ret) {
- fprintf(stderr, "ERROR: bpf_map_update_elem qidconf\n");
+int main(int argc, char **argv)
+{
+ struct rlimit r = {RLIM_INFINITY, RLIM_INFINITY};
+ pthread_t pt;
+ int ret;
+
+ signal(SIGINT, int_exit);
+ signal(SIGTERM, int_exit);
+ signal(SIGABRT, int_exit);
+
+ parse_command_line(argc, argv);
+
+ if (setrlimit(RLIMIT_MEMLOCK, &r)) {
+ fprintf(stderr, "ERROR: setrlimit(RLIMIT_MEMLOCK) \"%s\"\n",
+ strerror(errno));
exit(EXIT_FAILURE);
}
@@ -964,19 +985,7 @@ int main(int argc, char **argv)
xsks[num_socks++] = xsk_configure(xsks[0]->umem);
#endif
- /* ...and insert them into the map. */
- for (i = 0; i < num_socks; i++) {
- key = i;
- ret = bpf_map_update_elem(xsks_map, &key, &xsks[i]->sfd, 0);
- if (ret) {
- fprintf(stderr, "ERROR: bpf_map_update_elem %d\n", i);
- exit(EXIT_FAILURE);
- }
- }
-
- signal(SIGINT, int_exit);
- signal(SIGTERM, int_exit);
- signal(SIGABRT, int_exit);
+ setup_xdp_xskmap(argv[0]);
setlocale(LC_ALL, "");
--
2.19.1
next prev parent reply other threads:[~2018-12-17 10:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 10:24 [PATCH bpf-next v2 0/7] Add support for XDP_ATTACH Björn Töpel
2018-12-17 10:24 ` [PATCH bpf-next v2 1/7] xsk: simplify AF_XDP socket teardown Björn Töpel
2018-12-17 10:24 ` [PATCH bpf-next v2 2/7] xsk: add XDP_ATTACH bind() flag Björn Töpel
2018-12-17 10:24 ` [PATCH bpf-next v2 3/7] bpf: add bpf_xsk_redirect function Björn Töpel
2018-12-17 10:24 ` [PATCH bpf-next v2 4/7] tools/bpf: sync kernel uapi bpf.h to tools directory Björn Töpel
2018-12-17 10:24 ` [PATCH bpf-next v2 5/7] libbpf: initial support for builtin BPF programs Björn Töpel
2018-12-17 10:25 ` Björn Töpel [this message]
2018-12-17 10:25 ` [PATCH bpf-next v2 7/7] samples: bpf: add support for XDP_ATTACH to xdpsock Björn Töpel
2018-12-17 12:50 ` [PATCH bpf-next v2 0/7] Add support for XDP_ATTACH Jesper Dangaard Brouer
2018-12-17 13:39 ` Björn Töpel
2018-12-17 14:10 ` Jesper Dangaard Brouer
2018-12-17 14:55 ` Magnus Karlsson
2018-12-17 15:30 ` Björn Töpel
2018-12-18 23:04 ` Alexei Starovoitov
2018-12-19 9:34 ` Björn Töpel
2018-12-19 16:23 ` Jesper Dangaard Brouer
2018-12-20 0:48 ` Alexei Starovoitov
2018-12-18 2:36 ` Jakub Kicinski
2018-12-18 8:59 ` Björn Töpel
2018-12-18 18:18 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181217102501.22019-7-bjorn.topel@gmail.com \
--to=bjorn.topel@gmail.com \
--cc=andrew@lunn.ch \
--cc=ast@kernel.org \
--cc=bjorn.topel@intel.com \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=jakub.kicinski@netronome.com \
--cc=magnus.karlsson@gmail.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=qi.z.zhang@intel.com \
--cc=u9012063@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).