From: Pavel Machek <pavel@ucw.cz>
To: "Vokáč Michal" <Michal.Vokac@ysoft.com>, trivial@kernel.org
Cc: "andrew@lunn.ch" <andrew@lunn.ch>,
"vivien.didelot@savoirfairelinux.com"
<vivien.didelot@savoirfairelinux.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"buytenh@marvell.com" <buytenh@marvell.com>,
"buytenh@wantstofly.org" <buytenh@wantstofly.org>,
"nico@marvell.com" <nico@marvell.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dsa device tree bindings: fix typo and wrong example
Date: Mon, 7 Jan 2019 19:49:44 +0100 [thread overview]
Message-ID: <20190107184944.GA17979@amd> (raw)
In-Reply-To: <819595ee-9f3e-b7a2-6139-1ba265137f62@ysoft.com>
[-- Attachment #1: Type: text/plain, Size: 1759 bytes --]
On Thu 2018-12-06 13:28:56, Vokáč Michal wrote:
> On 6.12.2018 14:05, Pavel Machek wrote:
> >
> > Fix typo and fix compatible value that is not actually permitted by the
> > description in the example.
>
> Ahoj Pavle, I think the subject should be more like:
>
> "dt-bindings: net: dsa: ..."
Ahoj!
Well, retrying with different subject only makes sense if someone is
interested. Rob, Andrew -- can you take the patch?
Do you want me to edit the subject or can you just edit the subject
while applying?
Thanks,
Pavel
> BR, Michal
>
> >
> > Signed-off-by: Pavel Machek <pavel@ucw.cz>
> >
> > diff --git a/Documentation/devicetree/bindings/net/dsa/marvell.txt b/Documentation/devicetree/bindings/net/dsa/marvell.txt
> > index feb007af13cb..abf1be036ac5 100644
> > --- a/Documentation/devicetree/bindings/net/dsa/marvell.txt
> > +++ b/Documentation/devicetree/bindings/net/dsa/marvell.txt
> > @@ -41,7 +41,7 @@ Optional properties:
> > - mdio : Container of PHY and devices on the switches MDIO
> > bus.
> > - mdio? : Container of PHYs and devices on the external MDIO
> > - bus. The node must contains a compatible string of
> > + bus. The node must contain a compatible string of
> > "marvell,mv88e6xxx-mdio-external"
> >
> > Example:
> > @@ -80,7 +80,7 @@ Example:
> > #interrupt-cells = <2>;
> >
> > switch0: switch@0 {
> > - compatible = "marvell,mv88e6390";
> > + compatible = "marvell,mv88e6190";
> > reg = <0>;
> > reset-gpios = <&gpio5 1 GPIO_ACTIVE_LOW>;
> >
> >
> >
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-01-07 18:49 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 19:51 DSA support for Marvell 88e6065 switch Pavel Machek
2018-11-15 20:26 ` Andrew Lunn
2018-11-18 18:07 ` Pavel Machek
2018-11-18 18:20 ` Andrew Lunn
2018-11-18 20:15 ` Pavel Machek
2018-11-19 3:25 ` Andrew Lunn
2018-11-22 13:21 ` Pavel Machek
2018-11-22 15:33 ` Lennert Buytenhek
2018-11-22 20:27 ` Pavel Machek
2018-12-03 1:42 ` Lennert Buytenhek
2018-12-05 20:46 ` Pavel Machek
2018-12-05 22:20 ` Florian Fainelli
2018-12-06 14:40 ` Pavel Machek
2019-01-29 22:57 ` mv88e6xxx -- DSA support for Marvell 88e6065 switch (and maybe 88e6060?) Pavel Machek
2019-01-29 23:12 ` Andrew Lunn
2019-01-29 23:21 ` Vivien Didelot
2018-12-06 13:00 ` Well supported DSA switches, support for Marvell 88e6065 switch Pavel Machek
2018-12-06 13:01 ` [PATCH] mv88e6060: Warn about errors Pavel Machek
2018-12-06 20:21 ` David Miller
2018-12-06 20:36 ` Pavel Machek
2018-12-06 13:02 ` [RFD] mv88e6060: Allow the driver to be probed from device tree Pavel Machek
2018-12-06 18:32 ` kbuild test robot
2018-12-15 8:41 ` kbuild test robot
2018-12-06 13:03 ` mv88e6060: Turn e6060 driver into e6065 driver Pavel Machek
2018-12-06 20:23 ` David Miller
2018-12-06 20:35 ` Pavel Machek
2018-12-06 13:05 ` [PATCH] dsa device tree bindings: fix typo and wrong example Pavel Machek
2018-12-06 13:28 ` Vokáč Michal
2019-01-07 18:49 ` Pavel Machek [this message]
2019-01-07 18:53 ` Florian Fainelli
2018-12-06 13:06 ` [RFC] tag_daddr: add tagging scheme used by Marvel 88e6065 switch Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190107184944.GA17979@amd \
--to=pavel@ucw.cz \
--cc=Michal.Vokac@ysoft.com \
--cc=andrew@lunn.ch \
--cc=buytenh@marvell.com \
--cc=buytenh@wantstofly.org \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=nico@marvell.com \
--cc=robh+dt@kernel.org \
--cc=trivial@kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).