From: Nathan Chancellor <natechancellor@gmail.com>
To: Remi Denis-Courmont <courmisch@gmail.com>,
"David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Nick Desaulniers <ndesaulniers@google.com>
Subject: Clang warnings in net/phonet
Date: Mon, 7 Jan 2019 19:54:20 -0700 [thread overview]
Message-ID: <20190108025420.GA26093@flashbox> (raw)
Hi all,
When building the kernel with Clang, this warning comes up in net/phonet.
net/phonet/pep.c:224:16: warning: array index 1 is past the end of the array (which contains 1 element) [-Warray-bounds]
ph->data[0] = oph->data[1]; /* CTRL id */
^ ~
include/net/phonet/pep.h:66:3: note: array 'data' declared here
u8 data[1];
^
net/phonet/pep.c:281:10: warning: array index 1 is past the end of the array (which contains 1 element) [-Warray-bounds]
switch (hdr->data[1]) {
^ ~
include/net/phonet/pep.h:66:3: note: array 'data' declared here
u8 data[1];
^
net/phonet/pep.c:285:12: warning: array index 4 is past the end of the array (which contains 1 element) [-Warray-bounds]
switch (hdr->data[4]) {
^ ~
include/net/phonet/pep.h:66:3: note: array 'data' declared here
u8 data[1];
^
net/phonet/pep.c:295:8: warning: array index 4 is past the end of the array (which contains 1 element) [-Warray-bounds]
if (hdr->data[4] == PEP_IND_READY)
^ ~
include/net/phonet/pep.h:66:3: note: array 'data' declared here
u8 data[1];
^
net/phonet/pep.c:304:21: warning: array index 4 is past the end of the array (which contains 1 element) [-Warray-bounds]
atomic_add(wake = hdr->data[4], &pn->tx_credits);
^ ~
include/net/phonet/pep.h:66:3: note: array 'data' declared here
u8 data[1];
^
net/phonet/pep.c:509:9: warning: array index 4 is past the end of the array (which contains 1 element) [-Warray-bounds]
n_sb = hdr->data[4];
^ ~
include/net/phonet/pep.h:66:3: note: array 'data' declared here
u8 data[1];
^
net/phonet/pep.c:817:14: warning: array index 1 is past the end of the array (which contains 1 element) [-Warray-bounds]
peer_type = hdr->other_pep_type << 8;
^ ~~~~~~~~~~~~~~
include/net/phonet/pep.h:66:3: note: array 'data' declared here
u8 data[1];
^
net/phonet/pep.c:820:9: warning: array index 4 is past the end of the array (which contains 1 element) [-Warray-bounds]
n_sb = hdr->data[4];
^ ~
include/net/phonet/pep.h:66:3: note: array 'data' declared here
u8 data[1];
^
8 warnings generated.
I have taken a look at the effected code but I can't really figure out
the proper fix for this warning (my knowledge of C just isn't there
yet). Nick had suggested changing 'u8 data[1]' to 'u8 *data' in
'struct pnpipehdr', which seems logical but I can't say for sure. Any
advice would be appreciated :)
Thanks,
Nathan
next reply other threads:[~2019-01-08 2:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-08 2:54 Nathan Chancellor [this message]
2019-01-26 8:10 ` Clang warnings in net/phonet Nathan Chancellor
2019-02-19 21:50 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190108025420.GA26093@flashbox \
--to=natechancellor@gmail.com \
--cc=courmisch@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).