From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41CAEC2F441 for ; Mon, 21 Jan 2019 16:46:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0C5B521721 for ; Mon, 21 Jan 2019 16:46:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="LwGd/gDW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730680AbfAUQqD (ORCPT ); Mon, 21 Jan 2019 11:46:03 -0500 Received: from mail-eopbgr00084.outbound.protection.outlook.com ([40.107.0.84]:9952 "EHLO EUR02-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729974AbfAUQqD (ORCPT ); Mon, 21 Jan 2019 11:46:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=We5hrCmBhfJJQdyNYkkdw5nN2gYkLkcTRxgm1W0s5Bs=; b=LwGd/gDWfw9UZ/4XzR0OSO32EmTa/rVxCtkXOaC+Mnf3VUcEOEAD13Q1rQOPKTs+cITrjMPVbV5bMzMmagctrGLeBjtb2I4HJ5lbYAd5t8oh30S0XUlOfSMKseDRusekc7wZpMOYos/A9X09B6P0yYRLiWaVSjfl4R17OnAIeFg= Received: from HE1PR05MB4601.eurprd05.prod.outlook.com (20.176.163.138) by HE1PR05MB4524.eurprd05.prod.outlook.com (20.176.163.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1537.26; Mon, 21 Jan 2019 16:45:58 +0000 Received: from HE1PR05MB4601.eurprd05.prod.outlook.com ([fe80::75a0:a89d:1227:7ed3]) by HE1PR05MB4601.eurprd05.prod.outlook.com ([fe80::75a0:a89d:1227:7ed3%5]) with mapi id 15.20.1537.031; Mon, 21 Jan 2019 16:45:58 +0000 From: Jason Gunthorpe To: Leon Romanovsky CC: Saeed Mahameed , "netdev@vger.kernel.org" , "linux-rdma@vger.kernel.org" , Maxim Mikityanskiy , Eran Ben Elisha Subject: Re: [PATCH mlx5-next 4/4] net/mlx5: Remove spinlock support from mlx5_write64 Thread-Topic: [PATCH mlx5-next 4/4] net/mlx5: Remove spinlock support from mlx5_write64 Thread-Index: AQHUr469Vj10XdM6C0irA9oBgVV346W2NiYAgAO8RYA= Date: Mon, 21 Jan 2019 16:45:58 +0000 Message-ID: <20190121164551.GF25149@mellanox.com> References: <20190119003313.16711-1-saeedm@mellanox.com> <20190119003313.16711-5-saeedm@mellanox.com> <20190119074308.GH15600@mtr-leonro.mtl.com> In-Reply-To: <20190119074308.GH15600@mtr-leonro.mtl.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: MWHPR20CA0030.namprd20.prod.outlook.com (2603:10b6:300:ed::16) To HE1PR05MB4601.eurprd05.prod.outlook.com (2603:10a6:7:99::10) authentication-results: spf=none (sender IP is ) smtp.mailfrom=jgg@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [174.3.196.123] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;HE1PR05MB4524;6:nMRSQtJl6K5qKK/JMmELba1/qqPHu8L34ix8vK4JDdry0mABr0DhHExPbbgZdrnUosG0YvCL3UK52GEEG1VgLrTOj7yOi4D/8QtsswUfaBlO+v9yWjqmFIoZ4z0tbOoqP8UvA5Z/nkIH02H7zFboDo9S4pS4ayLW4JzssbWk58kYM1MOgYLs23/2XIVvQeYpGDo30df92iUYz02s27ndELdxCyEg81Jem3Y9Pa7mvDmUIrT9E7X7G6Yrm63MVtAj7Oj+R/11/8UeDKs9PSlVH0ZFo2T4LUeGMqE3SDozvgDiPvabt/sZYRrX4u2exUc08AKXEaxVJRGnBNj3ZR5nqy0rkxSz8sgaebtUySWrh5n3O8mY2Tm65eyThOImp5nx3Di1XPTMUy9v3DO29zh59vjvkUuiC/a/R8gX4QjmlacvXKGszyDFZ3oiz3IcB9wh1XYsaz7+FEl6kWbxqA7u3A==;5:NNAd/diyqekCJy7yRgM5wBVRPgKsxmcFn2dBcH8GL54VFbHs385G8Cn0QH5kVo/8cFbXHvsL0tePUGdDxmw5+5RLp3yW1E5Zzuow1KlwA40ePV3ucjYW6cIg218DDbufKcJIzjMjJkf8OYV3nJi2murSMq9icbY643EeiIEBXx1hGD8UG59JZgtcq7Mx8DlYDqGxfIqXeuBdip9MIwIiuQ==;7:/08RKw/NDO6kdFBWVOfXhdE98eVGW593MYty1mEYIND50shTmxaKK5jiKvNvf5Fvwo5QS/qadzNDyhTMPJ48QdBqa+4yAHVBVtisimjRY1yY1+aXQ2YUFw2Esi2SjRORHV2Cq4FNTsCNy3fUSQS7JQ== x-ms-office365-filtering-correlation-id: 85cbadac-8b11-49da-5978-08d67fbfeb4e x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(4534185)(4627221)(201703031133081)(201702281549075)(5600109)(711020)(4618075)(2017052603328)(7153060)(7193020);SRVR:HE1PR05MB4524; x-ms-traffictypediagnostic: HE1PR05MB4524: x-microsoft-antispam-prvs: x-forefront-prvs: 0924C6A0D5 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(39860400002)(376002)(346002)(366004)(136003)(396003)(199004)(189003)(186003)(7736002)(450100002)(6116002)(53936002)(305945005)(36756003)(37006003)(6862004)(102836004)(14454004)(52116002)(81156014)(8676002)(99286004)(6246003)(8936002)(4326008)(26005)(81166006)(33656002)(3846002)(86362001)(68736007)(107886003)(386003)(6506007)(4744005)(11346002)(66066001)(229853002)(316002)(25786009)(446003)(2616005)(476003)(14444005)(6436002)(1076003)(2906002)(486006)(71190400001)(6486002)(54906003)(97736004)(6512007)(76176011)(105586002)(106356001)(71200400001)(6636002)(256004)(478600001);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR05MB4524;H:HE1PR05MB4601.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 6k/uyPxiO+LTarjXVGYtys7Hxpo/sb77YfFNYFeeTOFgsnleFcIGvPtrRxRewOClWCjEpSL+1xYOstL4etvRPZYlvrIHPNJPzPKQzsqw7mSye8mrMCmrF2dO2k/7X6ZJ/H1BJ8ubYym5PgMY56AftABcoRgCl/YML0CHHEzv5D6v1kWnhAa1HT5VTDI5ktvKpbJqR1qEBbz/+UCZcSETXr/bSQNnrrEWaY5bOIYtUfB8gaRDQABR3jDW41+lP43OpCS5tlB5fRWRebApQ3iCs7Dszq+BpwjZBYQ9spNxK9xWVV54ybYkvtnnAjFabxpEJXTY4buaeyvu4wz8uhi47TE2cNos9tMNQ1Q0hY1mJ9wpDBLbg9qrk5W7tfYlmNZE6w0v82vQeyf7d8JQJxuVJr3BpurTjkuBkhCz2R4/uwY= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <8F2FC08BB4A8604D9574BF733ECC30E2@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 85cbadac-8b11-49da-5978-08d67fbfeb4e X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jan 2019 16:45:58.2755 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR05MB4524 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, Jan 19, 2019 at 12:43:14AM -0700, Leon Romanovsky wrote: > You need to do one of two things: > 1. Require CONFIG_64BIT and delete this 32bit code. > 2. Declare global mlx5 DB spinlock and use on 32bit systems, something > like this: > #if BITS_PER_LONG =3D=3D 64 > __raw_writeq(*(u64 *)val, dest); > #else > spin_lock_irqsave(doorbell_lock, flags); > __raw_writel((__force u32) val[0], dest); > __raw_writel((__force u32) val[1], dest + 4); > spin_unlock_irqrestore(doorbell_lock, flags); > #endif And why is this code using the __raw_ versions? Seems wrong too... Jason