From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFAE2C282C0 for ; Thu, 24 Jan 2019 01:01:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9D5D321872 for ; Thu, 24 Jan 2019 01:01:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726366AbfAXBBB (ORCPT ); Wed, 23 Jan 2019 20:01:01 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:51650 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726235AbfAXBBA (ORCPT ); Wed, 23 Jan 2019 20:01:00 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id C9A52100A50C2; Wed, 23 Jan 2019 17:00:59 -0800 (PST) Date: Wed, 23 Jan 2019 17:00:57 -0800 (PST) Message-Id: <20190123.170057.1824955058543142908.davem@davemloft.net> To: f.fainelli@gmail.com Cc: antoine.tenart@bootlin.com, sd@queasysnail.net, andrew@lunn.ch, hkallweit1@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, alexandre.belloni@bootlin.com, quentin.schulz@bootlin.com, allan.nielsen@microchip.com Subject: Re: [PATCH net-next 03/10] net: macsec: move some definitions in a dedicated header From: David Miller In-Reply-To: <955d1bdf-037e-ae26-a9da-8da2a51a7cbd@gmail.com> References: <20190123155638.13852-1-antoine.tenart@bootlin.com> <20190123155638.13852-4-antoine.tenart@bootlin.com> <955d1bdf-037e-ae26-a9da-8da2a51a7cbd@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 23 Jan 2019 17:01:00 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Florian Fainelli Date: Wed, 23 Jan 2019 12:11:37 -0800 > On 1/23/19 7:56 AM, Antoine Tenart wrote: >> This patch moves some structure, type and identifier definitions into a >> MACsec specific header. This patch does not modify how the MACsec code >> is running and only move things around. This is a preparation for the >> future MACsec hardware offloading support, which will re-use those >> definitions outside macsec.c. >> >> Signed-off-by: Antoine Tenart >> --- >> drivers/net/macsec.c | 164 +-------------------------------------- >> include/net/macsec.h | 178 +++++++++++++++++++++++++++++++++++++++++++ >> 2 files changed, 179 insertions(+), 163 deletions(-) >> create mode 100644 include/net/macsec.h >> >> diff --git a/drivers/net/macsec.c b/drivers/net/macsec.c >> index 56e354305f76..c3a138dd4386 100644 >> --- a/drivers/net/macsec.c >> +++ b/drivers/net/macsec.c >> @@ -17,10 +17,9 @@ >> #include >> #include >> >> +#include >> #include > > I would probably go with include/linux/if_macsec.h and have > uapi/linux/if_macsec.h include that file directly. This would be > consistent with other types of network interfaces: bridge, vlan etc. Agreed.