From: David Miller <davem@davemloft.net>
To: atsushi.nemoto@sord.co.jp
Cc: thor.thayer@linux.intel.com, netdev@vger.kernel.org,
dalon.westergreen@linux.intel.com, tomonori.sakita@sord.co.jp
Subject: Re: [PATCH v2] net: altera_tse: fix msgdma_tx_completion on non-zero fill_level case
Date: Sun, 27 Jan 2019 10:41:12 -0800 (PST) [thread overview]
Message-ID: <20190127.104112.895755013017380628.davem@davemloft.net> (raw)
In-Reply-To: <20190125.110222.956948485194493083.atsushi.nemoto@sord.co.jp>
From: Atsushi Nemoto <atsushi.nemoto@sord.co.jp>
Date: Fri, 25 Jan 2019 11:02:22 +0900
> From: Tomonori Sakita <tomonori.sakita@sord.co.jp>
>
> If fill_level was not zero and status was not BUSY,
> result of "tx_prod - tx_cons - inuse" might be zero.
> Subtracting 1 unconditionally results invalid negative return value
> on this case.
> Make sure not to return an negative value.
>
> Signed-off-by: Tomonori Sakita <tomonori.sakita@sord.co.jp>
> Signed-off-by: Atsushi Nemoto <atsushi.nemoto@sord.co.jp>
> Reviewed-by: Dalon L Westergreen <dalon.westergreen@linux.intel.com>
> ---
> Changes in v2:
> Use max_t instead of just removing the "- 1".
Applied.
prev parent reply other threads:[~2019-01-27 18:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 2:02 [PATCH v2] net: altera_tse: fix msgdma_tx_completion on non-zero fill_level case Atsushi Nemoto
2019-01-25 15:03 ` Thor Thayer
2019-01-27 18:41 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190127.104112.895755013017380628.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=atsushi.nemoto@sord.co.jp \
--cc=dalon.westergreen@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=thor.thayer@linux.intel.com \
--cc=tomonori.sakita@sord.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).