From: David Miller <davem@davemloft.net>
To: miquel.raynal@bootlin.com
Cc: andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
thomas.petazzoni@bootlin.com, gregory.clement@bootlin.com,
antoine.tenart@bootlin.com, maxime.chevallier@bootlin.com,
nadavh@marvell.com
Subject: Re: [PATCH net-next v2 0/2] mv88e6xxx DSA suspend to RAM support
Date: Sun, 27 Jan 2019 13:22:50 -0800 (PST) [thread overview]
Message-ID: <20190127.132250.578158295862987283.davem@davemloft.net> (raw)
In-Reply-To: <20190125095507.29334-1-miquel.raynal@bootlin.com>
From: Miquel Raynal <miquel.raynal@bootlin.com>
Date: Fri, 25 Jan 2019 10:55:05 +0100
> After a first attempt of bringing S2RAM support to the DSA switch, it
> has been reported that a part of the configuration was lost during the
> cycle. This second version adds a first patch that saves the rules in
> a per-chip list when they are applied, so that in the second patch we
> bring S2RAM support by also re-applying these rules.
...
It seems like the discussion on patch #1 has hit a brick wall.
The last suggestion was to use:
+ switch (mode) {
+ case PHY_INTERFACE_MODE_2500BASEX:
+ phydev->speed = SPEED_2500;
+ break;
+ case PHY_INTERFACE_MODE_10GKR:
+ phydev->speed = SPEED_10000;
+ break;
+
in dsa_port_fixed_link_register_of(), but that doesn't work
because swphy will fail without speed=1000 in the dts.
Well, whatever is decided, the commit message need to be updated
to explain why this course of action for the most immediate fix
was ultimately taken.
Thanks.
next prev parent reply other threads:[~2019-01-27 21:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 9:55 [PATCH net-next v2 0/2] mv88e6xxx DSA suspend to RAM support Miquel Raynal
2019-01-25 9:55 ` [PATCH net-next v2 1/2] net: dsa: mv88e6xxx: Save switch rules Miquel Raynal
2019-01-25 18:37 ` Florian Fainelli
2019-01-28 14:24 ` Miquel Raynal
2019-01-28 14:44 ` Andrew Lunn
2019-01-28 15:57 ` Miquel Raynal
2019-01-28 17:42 ` Andrew Lunn
2019-01-29 9:01 ` Miquel Raynal
2019-01-29 14:51 ` Andrew Lunn
2019-01-29 15:46 ` Vivien Didelot
2019-01-30 9:46 ` Miquel Raynal
2019-01-30 14:54 ` Andrew Lunn
2019-01-31 0:46 ` Vivien Didelot
2019-02-01 11:01 ` Miquel Raynal
2019-02-01 14:08 ` Andrew Lunn
2019-02-01 14:43 ` Miquel Raynal
2019-01-25 9:55 ` [PATCH net-next v2 2/2] net: dsa: mv88e6xxx: Add suspend to RAM support Miquel Raynal
2019-01-27 21:22 ` David Miller [this message]
2019-01-27 21:46 ` [PATCH net-next v2 0/2] mv88e6xxx DSA " Andrew Lunn
2019-01-28 3:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190127.132250.578158295862987283.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=antoine.tenart@bootlin.com \
--cc=f.fainelli@gmail.com \
--cc=gregory.clement@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=miquel.raynal@bootlin.com \
--cc=nadavh@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).