From: David Miller <davem@redhat.com>
To: nird@mellanox.com
Cc: netdev@vger.kernel.org, nikolay@cumulusnetworks.com, mlxsw@mellanox.com
Subject: Re: [PATCH net] ip6mr: Fix notifiers call on mroute_clean_tables()
Date: Sun, 27 Jan 2019 23:17:19 -0800 (PST) [thread overview]
Message-ID: <20190127.231719.285504281465860129.davem@redhat.com> (raw)
In-Reply-To: <20190127072622.24835-1-nird@mellanox.com>
From: Nir Dotan <nird@mellanox.com>
Date: Sun, 27 Jan 2019 09:26:22 +0200
> When the MC route socket is closed, mroute_clean_tables() is called to
> cleanup existing routes. Mistakenly notifiers call was put on the cleanup
> of the unresolved MC route entries cache.
> In a case where the MC socket closes before an unresolved route expires,
> the notifier call leads to a crash, caused by the driver trying to
> increment a non initialized refcount_t object [1] and then when handling
> is done, to decrement it [2]. This was detected by a test recently added in
> commit 6d4efada3b82 ("selftests: forwarding: Add multicast routing test").
>
> Fix that by putting notifiers call on the resolved entries traversal,
> instead of on the unresolved entries traversal.
...
> Fixes: 088aa3eec2ce ("ip6mr: Support fib notifications")
> Signed-off-by: Nir Dotan <nird@mellanox.com>
> Reviewed-by: Ido Schimmel <idosch@mellanox.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2019-01-28 7:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-27 7:26 [PATCH net] ip6mr: Fix notifiers call on mroute_clean_tables() Nir Dotan
2019-01-28 7:17 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190127.231719.285504281465860129.davem@redhat.com \
--to=davem@redhat.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=nird@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).