From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=xXtl=QD=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT
	autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id BE290C282CA
	for <netdev@archiver.kernel.org>; Sun, 27 Jan 2019 20:20:16 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 80A1F2087F
	for <netdev@archiver.kernel.org>; Sun, 27 Jan 2019 20:20:16 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="i7X6dE/p"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726920AbfA0UTd (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Sun, 27 Jan 2019 15:19:33 -0500
Received: from vps0.lunn.ch ([185.16.172.187]:56760 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726386AbfA0UTc (ORCPT <rfc822;netdev@vger.kernel.org>);
        Sun, 27 Jan 2019 15:19:32 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:
        Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:
        Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
        :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
        List-Post:List-Owner:List-Archive;
        bh=+zkfAzy1TvOm5+5gvVfPpUxvdIR/rsEYJUNq14UlhRU=; b=i7X6dE/pXuQffLeSwuqxNMhg45
        /m04p2puHjWJLaHrRebcp+P5rtBTIAG7L+50T87MxSApvMcZFZrv8MD6LMLGSbyVt3aydjl4+k53W
        tddRtoRgxnQ06WbbBgL5Tp9Dwqs/vCeb1+Kg0pUxfusObMHQJ7OHeHcH91MnjC3hfbec=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.89)
        (envelope-from <andrew@lunn.ch>)
        id 1gnqto-0000Qi-Nf; Sun, 27 Jan 2019 21:19:24 +0100
Date:   Sun, 27 Jan 2019 21:19:24 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     "Yavuz, Tuba" <tuba@ece.ufl.edu>
Cc:     Greg KH <greg@kroah.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>
Subject: Re: Error in the hso driver
Message-ID: <20190127201924.GA32046@lunn.ch>
References: <1548614320825.86428@ece.ufl.edu>
 <20190127193503.GC25051@kroah.com>
 <1548618592071.43193@ece.ufl.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1548618592071.43193@ece.ufl.edu>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Sun, Jan 27, 2019 at 07:49:52PM +0000, Yavuz, Tuba wrote:
> Here is a proposed patch:
> 
> --- drivers/net/usb/hso.c.orig	2019-01-27 14:45:58.232683119 -0500
> +++ drivers/net/usb/hso.c	2019-01-27 14:47:43.592683629 -0500
> @@ -2377,7 +2377,7 @@ static void hso_free_net_device(struct h
>  
>  	remove_net_device(hso_net->parent);
>  
> -	if (hso_net->net)
> +	if (hso_net->net && hso_net->net->reg_state == NETREG_REGISTERED)
>  		unregister_netdev(hso_net->net);
>  
>  	/* start freeing */

Hi Tuba

Using the free function from the probe often has problems. It is
better to put the cleanup at the end of the probe, and use a
collection of goto's and labels.

	   Andrew