From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9EB5C282CA for ; Sun, 27 Jan 2019 20:55:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9798B21473 for ; Sun, 27 Jan 2019 20:55:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726979AbfA0Uz5 (ORCPT ); Sun, 27 Jan 2019 15:55:57 -0500 Received: from torres.zugschlus.de ([85.214.131.164]:58074 "EHLO torres.zugschlus.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726232AbfA0Uz5 (ORCPT ); Sun, 27 Jan 2019 15:55:57 -0500 Received: from mh by torres.zugschlus.de with local (Exim 4.89) (envelope-from ) id 1gnrT9-0005h5-5y; Sun, 27 Jan 2019 21:55:55 +0100 Date: Sun, 27 Jan 2019 21:55:55 +0100 From: Marc Haber To: Heiner Kallweit Cc: "netdev@vger.kernel.org" Subject: Re: WoL broken in r8169.c since kernel 4.19 Message-ID: <20190127205555.GF27062@torres.zugschlus.de> References: <20190122161005.GA27062@torres.zugschlus.de> <3c3249f8-6e09-43a7-e4e2-f4fc2b9531ab@gmail.com> <20190125055919.GB27062@torres.zugschlus.de> <6ae02156-8903-70fd-675f-a5aee9c452b4@gmail.com> <20190125120210.GC27062@torres.zugschlus.de> <548c1682-ad7c-3a0a-b2ea-2207f328b070@gmail.com> <20190126135640.GD27062@torres.zugschlus.de> <1a17454a-3017-7283-89d6-206681ca4c47@gmail.com> <20190126170752.GE27062@torres.zugschlus.de> <6ecafe07-3278-a9c4-d76d-971c0df26ce8@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <6ecafe07-3278-a9c4-d76d-971c0df26ce8@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, Jan 26, 2019 at 08:22:33PM +0100, Heiner Kallweit wrote: > You could go with this range: > from 4ff364662814 ("r8169: replace get_protocol with vlan_get_protocol") > to 649f0837a8cc ("r8169: fix broken Wake-on-LAN from S5 (poweroff)") I am quite inexperienced with bisecting and am therefore giving a better account of my actions here. [2/4994]mh@fan:~/linux/git/linux ((v4.18.16) %) $ git pull remote: Counting objects: 786, done. remote: Compressing objects: 100% (197/197), done. remote: Total 786 (delta 659), reused 697 (delta 589) Receiving objects: 100% (786/786), 146.00 KiB | 1.20 MiB/s, done. Resolving deltas: 100% (659/659), completed with 237 local objects. >From git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux ba6069759381..1fc7f56db7a7 master -> origin/master You are not currently on a branch. 1 [3/4995]mh@fan:~/linux/git/linux ((v4.18.16) %) $ git checkout 4ff364662814 Checking out files: 100% (13994/13994), done. Previous HEAD position was 6b3252287aa2 Linux 4.18.16 HEAD is now at 4ff364662814 r8169: replace get_protocol with vlan_get_protocol [4/4996]mh@fan:~/linux/git/linux ((4ff364662814...) %) $ git bisect start drivers/net/ethernet/realtek/r8169.c [5/4997]mh@fan:~/linux/git/linux ((4ff364662814...) %|BISECTING) $ (copy 4.20 config, make oldconfig, say no to everything, make deb-pkg, install and try) this boots and wakes up on magic packet from suspend to ram [2/4994]mh@fan:~/linux/git/linux ((4ff364662814...) *%|BISECTING) $ git bisect good [3/4995]mh@fan:~/linux/git/linux ((4ff364662814...) *%|BISECTING) $ git checkout 649f0837a8cc Checking out files: 100% (21794/21794), done. M scripts/package/Makefile Previous HEAD position was 4ff364662814 r8169: replace get_protocol with vlan_get_protocol HEAD is now at 649f0837a8cc r8169: fix broken Wake-on-LAN from S5 (poweroff) [4/4996]mh@fan:~/linux/git/linux ((649f0837a8cc...) *%|BISECTING) $ (copy 4.20 config, make oldconfig, say no to everything, make deb-pkg, install and try) this boots and does not wake up from StR on magic packet, after waking up with any key on the keyboard I had an amdgpu issue on the console and a dead console, but was able to ssh in and reboot. [2/4994]mh@fan:~/linux/git/linux ((649f0837a8cc...) *%|BISECTING) $ git bisect bad Bisecting: 33 revisions left to test after this (roughly 5 steps) [098b01ad9837b4d4d0022f407300f069a999e55a] r8169: don't include asm headers directly [3/4995]mh@fan:~/linux/git/linux ((098b01ad9837...) *%|BISECTING) $ I think I am on the right way here, am I? Greetings Marc -- ----------------------------------------------------------------------------- Marc Haber | "I don't trust Computers. They | Mailadresse im Header Leimen, Germany | lose things." Winona Ryder | Fon: *49 6224 1600402 Nordisch by Nature | How to make an American Quilt | Fax: *49 6224 1600421