From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 800B8C282C8 for ; Mon, 28 Jan 2019 19:38:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 291952171F for ; Mon, 28 Jan 2019 19:38:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b="BkPqfV/E"; dkim=pass (1024-bit key) header.d=marvell.onmicrosoft.com header.i=@marvell.onmicrosoft.com header.b="S4fHNAgn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727240AbfA1Tii (ORCPT ); Mon, 28 Jan 2019 14:38:38 -0500 Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]:60960 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726774AbfA1Tih (ORCPT ); Mon, 28 Jan 2019 14:38:37 -0500 Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x0SJTtZJ003645; Mon, 28 Jan 2019 11:38:34 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : content-type : content-id : content-transfer-encoding : mime-version; s=pfpt0818; bh=W2ojZUMgj1NASmu2qt7bj7OrMrHBujPJMxaK0hETza4=; b=BkPqfV/EiG1EL8g34qOZ3WM4EZ5QntLIC9tehTNh2rBypfU27snL7cF7x0/a0KLJiH2m p2DKTF90RnFBLZxPTFPEPfQ/gwq4J79lKRbh0tYuTAZ6wAQ5jKyP8T+wmLNf7VFrz5PW 8pxV1MD/6Lq7BI9wr5kjJI2+Gmvmk0XMhyS1ykxtJ3lan9PMdkbFb1FYke9aQKhdcRz8 mz9BrrkEg1bst2PZFu1s/7rIcbvTk+xDAMhJrCgqVIBaBsoq/IoQTcO9To70+lupJbvu D1QXcrC7jdotA2s1MxNxdozKOdir+WQvpqPwc9AjwBdCUxE46LanX0AMaky2bIbNxa+G FQ== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0b-0016f401.pphosted.com with ESMTP id 2qa5mt0nw7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 28 Jan 2019 11:38:34 -0800 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 28 Jan 2019 11:38:33 -0800 Received: from NAM01-SN1-obe.outbound.protection.outlook.com (104.47.32.56) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Mon, 28 Jan 2019 11:38:33 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W2ojZUMgj1NASmu2qt7bj7OrMrHBujPJMxaK0hETza4=; b=S4fHNAgnxmubOTFqO6hFjwV94xqegzBZCL0r2TNZo45y9oY8bxKrVS1lawnvnmcb8LlOMzpDYHFeHmTGKLN2g5tN5wjL45qKNWcPW8lsdd6fc6pv31m9HqL/A6aT0B+loXu6Z6X/fRqEDaY4CbsMRGXBPM3aDwP0GhilRreqDwA= Received: from BYAPR18MB2712.namprd18.prod.outlook.com (20.179.56.74) by BYAPR18MB2629.namprd18.prod.outlook.com (20.179.93.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1558.17; Mon, 28 Jan 2019 19:38:31 +0000 Received: from BYAPR18MB2712.namprd18.prod.outlook.com ([fe80::192c:8e83:d401:6f8a]) by BYAPR18MB2712.namprd18.prod.outlook.com ([fe80::192c:8e83:d401:6f8a%5]) with mapi id 15.20.1558.023; Mon, 28 Jan 2019 19:38:31 +0000 From: Felix Manlunas To: "davem@davemloft.net" CC: "netdev@vger.kernel.org" , Derek Chickles , Satananda Burla , Felix Manlunas , Veerasenareddy Burru Subject: [PATCH net-next] liquidio: fix the validation of rx checksum status from NIC hardware Thread-Topic: [PATCH net-next] liquidio: fix the validation of rx checksum status from NIC hardware Thread-Index: AQHUt0EMDunKzO7hdU+Zu6yWyapqdw== Date: Mon, 28 Jan 2019 19:38:31 +0000 Message-ID: <20190128193828.GA32464@felix-thinkpad.marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: BYAPR01CA0008.prod.exchangelabs.com (2603:10b6:a02:80::21) To BYAPR18MB2712.namprd18.prod.outlook.com (2603:10b6:a03:103::10) x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [67.180.122.75] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;BYAPR18MB2629;20:6PWkc4Pp6SdCZccP8VI7NJwLcUngL4aUunWFD4rvgYqZzxkiqqzs3FQ1E1QbwKcPtcNNzkYA7QZvCp/rGRWLsIrjt/j+8Td/YiIFHCW6z2CcL6vYOyl3uJf2k/JIo85rPz3cQKikst+KN8JzAazuz04FG2DUK5dAUDmpXpu6XoA= x-ms-office365-filtering-correlation-id: c1b3deb7-65b9-4de4-4fb5-08d685582f11 x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605077)(2017052603328)(7153060)(7193020);SRVR:BYAPR18MB2629; x-ms-traffictypediagnostic: BYAPR18MB2629: x-microsoft-antispam-prvs: x-forefront-prvs: 0931CB1479 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(979002)(396003)(376002)(136003)(346002)(39860400002)(366004)(189003)(199004)(81156014)(1730700003)(81166006)(8676002)(478600001)(8936002)(486006)(102836004)(66066001)(6116002)(4326008)(386003)(7736002)(107886003)(2501003)(6916009)(305945005)(14454004)(316002)(476003)(256004)(14444005)(26005)(6506007)(68736007)(25786009)(3846002)(105586002)(2906002)(52116002)(33656002)(54906003)(2351001)(6486002)(106356001)(6436002)(186003)(5640700003)(71200400001)(71190400001)(97736004)(86362001)(6512007)(53936002)(99286004)(1076003)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:BYAPR18MB2629;H:BYAPR18MB2712.namprd18.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: BYlmP1whJ9kB96FQbKjgja6wi9K0rrpve+nq1BQIW9mGKvWU3FOb5gR2dg6XvcoLqdtZnPY16KIcnMJJmlYDblUymXB7OJzEDeC5c+W7oi6Zm3Laxj82TYAlCCPNSHh8BvOiGHl7Q3410Z2o5P/orZcBeP72nTZDDqsSO/8z7eURdScYO1S5eRNY8MsvfSduosX4ghQ4yDxBaoXCwK7BdWFBa2vwp8uGR9oDnSAREUD07v/RftjnwyRvPae/KFiTPZWRvMK9AHfMy+aEEH4ACqSiNw1iH5ljJYubmbz9qHe0SSBflyitsrSfAZrqkHJBGa1D7ySbv3mIP9r/scB/OkA2PFNjJW0ofKA4lY5pbq8FQ8Fzr6kumaSZtGRbMR+1o/s4wwvMg/oDoh+WdXOPPJaGREAARVKL0ydUsOPlwqw= Content-Type: text/plain; charset="us-ascii" Content-ID: <27021E0FA295A7438F8AD7BF03D2C001@namprd18.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: c1b3deb7-65b9-4de4-4fb5-08d685582f11 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jan 2019 19:38:31.2343 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2629 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-01-28_09:,, signatures=0 X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=957 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1901280145 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Veerasenareddy Burru Fixed the code that was incorrectly interpreting the rx checksum validation status from hardware, and updating kernel that the packet arrived with correct checksum though the packet arrived with incorrect checksum and hardware also indicated checksum is not correct. Signed-off-by: Veerasenareddy Burru Acked-by: Derek Chickles Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cavium/liquidio/lio_core.c=20 b/drivers/net/ethernet/cavium/liquidio/lio_core.c index 825a28e..e21bf37 100644 --- a/drivers/net/ethernet/cavium/liquidio/lio_core.c +++ b/drivers/net/ethernet/cavium/liquidio/lio_core.c @@ -661,7 +661,8 @@ static int octeon_setup_droq(struct octeon_device *oct,= int q_no, int num_descs, (((rh->r_dh.encap_on) && (rh->r_dh.csum_verified & CNNIC_TUN_CSUM_VERIFIED)) || (!(rh->r_dh.encap_on) && - (rh->r_dh.csum_verified & CNNIC_CSUM_VERIFIED)))) + ((rh->r_dh.csum_verified & CNNIC_CSUM_VERIFIED) =3D=3D + CNNIC_CSUM_VERIFIED)))) /* checksum has already been verified */ skb->ip_summed =3D CHECKSUM_UNNECESSARY; else --=20 1.8.3.1