From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72892C282D8 for ; Fri, 1 Feb 2019 14:15:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3122421872 for ; Fri, 1 Feb 2019 14:15:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549030527; bh=NGy+6BWRcUN1def+fXwbBaBMZxwbh9k+nVLEWG0TADQ=; h=Date:From:To:Subject:List-ID:From; b=oydg3/+blNwHkapr11mK6xSxPl6hHSATpvWdfcwU1ZHEp5XBbYJKsbF0hpgSnNCFK lWyVbRTddCh2TPdT+V7ftJXv1kY1ZD/3NLYoDknTKK8vVf0HoJKCYEeqr9MKLHkUhY WPBmkBpyZkqkpJZGHI66uJZOtY7M7UV7zDnrG8DE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729447AbfBAOP0 (ORCPT ); Fri, 1 Feb 2019 09:15:26 -0500 Received: from mail.kernel.org ([198.145.29.99]:36644 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726926AbfBAOP0 (ORCPT ); Fri, 1 Feb 2019 09:15:26 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2486F2086C; Fri, 1 Feb 2019 14:15:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549030525; bh=NGy+6BWRcUN1def+fXwbBaBMZxwbh9k+nVLEWG0TADQ=; h=Date:From:To:Subject:From; b=dacbPeoD1QnXp3ZCeqvbXKZj0aXK/Yjq29pNbzkLMAKb+IEy4N6o/N0J/KeEvJN05 TwELhzjuahmtNDBmS5awc87gb8Vx1FFKo0iV6XfFJDqAX65Sk0DKE1A7rIHI2ZD5Fs hdqE9KUbXzTgBrBZb6ST06CfQL6NwSmjEd0hFrpg= Date: Fri, 1 Feb 2019 15:15:22 +0100 From: Greg Kroah-Hartman To: Vlad Yasevich , Neil Horman , Marcelo Ricardo Leitner , linux-sctp@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH net] sctp: walk the list of asoc safely Message-ID: <20190201141522.GA20785@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.11.2 (2019-01-07) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org In sctp_sendmesg(), when walking the list of endpoint associations, the association can be dropped from the list, making the list corrupt. Properly handle this by using list_for_each_entry_safe() Fixes: 4910280503f3 ("sctp: add support for snd flag SCTP_SENDALL process in sendmsg") Reported-by: Secunia Research Tested-by: Secunia Research Signed-off-by: Greg Kroah-Hartman diff --git a/net/sctp/socket.c b/net/sctp/socket.c index f93c3cf9e567..65d6d04546ae 100644 --- a/net/sctp/socket.c +++ b/net/sctp/socket.c @@ -2027,7 +2027,7 @@ static int sctp_sendmsg(struct sock *sk, struct msghdr *msg, size_t msg_len) struct sctp_endpoint *ep = sctp_sk(sk)->ep; struct sctp_transport *transport = NULL; struct sctp_sndrcvinfo _sinfo, *sinfo; - struct sctp_association *asoc; + struct sctp_association *asoc, *tmp; struct sctp_cmsgs cmsgs; union sctp_addr *daddr; bool new = false; @@ -2053,7 +2053,7 @@ static int sctp_sendmsg(struct sock *sk, struct msghdr *msg, size_t msg_len) /* SCTP_SENDALL process */ if ((sflags & SCTP_SENDALL) && sctp_style(sk, UDP)) { - list_for_each_entry(asoc, &ep->asocs, asocs) { + list_for_each_entry_safe(asoc, tmp, &ep->asocs, asocs) { err = sctp_sendmsg_check_sflags(asoc, sflags, msg, msg_len); if (err == 0)