From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5291C282C4 for ; Thu, 7 Feb 2019 13:59:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 907B62190C for ; Thu, 7 Feb 2019 13:59:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="Obd6U6sB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726960AbfBGN7m (ORCPT ); Thu, 7 Feb 2019 08:59:42 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:42426 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726782AbfBGN7m (ORCPT ); Thu, 7 Feb 2019 08:59:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=MHHtCsoQdBIpDqpQB8CcP8mcYGHnSvU4DJ9anatzKPE=; b=Obd6U6sBiWm1B6RyOFtp8V4v98 1JeO/avOG2Aqag5sW3q8apaLY8ui22TkzlD7DUXkDdR7zHihd423f0cqy4Wrjg544bJB890hf1c/X k/M7Y3B05VhW50sfaB5dMS9DQUtlTdECxmblCj9mACbV5qdO7tJay2PyfVaThDVNM44E=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1grkDK-0006qj-7U; Thu, 07 Feb 2019 14:59:38 +0100 Date: Thu, 7 Feb 2019 14:59:38 +0100 From: Andrew Lunn To: Maxime Chevallier Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Florian Fainelli , Heiner Kallweit , Russell King , linux-arm-kernel@lists.infradead.org, Antoine Tenart , thomas.petazzoni@bootlin.com, gregory.clement@bootlin.com, miquel.raynal@bootlin.com, nadavh@marvell.com, stefanc@marvell.com, mw@semihalf.com Subject: Re: [PATCH net-next v2 02/10] net: phy: Mask-out non-compatible modes when setting the max-speed Message-ID: <20190207135938.GG32483@lunn.ch> References: <20190207094939.27369-1-maxime.chevallier@bootlin.com> <20190207094939.27369-3-maxime.chevallier@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190207094939.27369-3-maxime.chevallier@bootlin.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Feb 07, 2019 at 10:49:31AM +0100, Maxime Chevallier wrote: > When setting a PHY's max speed using either the max-speed DT property > or ethtool, we should mask-out all non-compatible modes according to the > settings table, instead of just the 10/100BASET modes. > > Signed-off-by: Maxime Chevallier > Suggested-by: Russell King Reviewed-by: Andrew Lunn Andrew